]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
python-common/service_spec: fix zonegroup_hostnames type
authorAdam King <adking@redhat.com>
Mon, 12 Aug 2024 14:10:42 +0000 (10:10 -0400)
committerAdam King <adking@redhat.com>
Mon, 12 Aug 2024 18:49:17 +0000 (14:49 -0400)
This was meant to be a list of strings. The only use for it
was passing it to the rgw module with a mon_command call
so mypy didn't notice. New work to use this field for
custom SANs entries into self-signed certs revealed the issue

Signed-off-by: Adam King <adking@redhat.com>
src/python-common/ceph/deployment/service_spec.py

index a69b3a25dcd3e84a80222b4c64944b54238bdecb..7853df6b554ba6c2edda7f16385fa2e573b37949 100644 (file)
@@ -1221,7 +1221,7 @@ class RGWSpec(ServiceSpec):
                  rgw_realm_token: Optional[str] = None,
                  update_endpoints: Optional[bool] = False,
                  zone_endpoints: Optional[str] = None,  # comma separated endpoints list
-                 zonegroup_hostnames: Optional[str] = None,
+                 zonegroup_hostnames: Optional[List[str]] = None,
                  rgw_user_counters_cache: Optional[bool] = False,
                  rgw_user_counters_cache_size: Optional[int] = None,
                  rgw_bucket_counters_cache: Optional[bool] = False,