mgr/localpool: use Option to define module options

more type safe this way

Signed-off-by: Kefu Chai <kchai@redhat.com>

diff --git a/src/pybind/mgr/localpool/module.py b/src/pybind/mgr/localpool/module.py
index 23ffeaa12de1f6aaabd5d693dea34b56f20d95e6..fbedc55f1ede3548084fd6ed0cb9ac4d88916384 100644 (file)
--- a/src/pybind/mgr/localpool/module.py
+++ b/src/pybind/mgr/localpool/module.py
@@ -1,51 +1,45 @@
-from mgr_module import MgrModule, CommandResult
+from mgr_module import MgrModule, CommandResult, Option
 import json
 import threading
 
 class Module(MgrModule):
 
     MODULE_OPTIONS = [
-        {
-            'name': 'subtree',
-            'type': 'str',
-            'default': 'rack',
-            'desc': 'CRUSH level for which to create a local pool',
-            'runtime': True,
-        },
-        {
-            'name': 'failure_domain',
-            'type': 'str',
-            'default': 'host',
-            'desc': 'failure domain for any created local pool',
-            'runtime': True,
-        },
-        {
-            'name': 'min_size',
-            'type': 'int',
-            'desc': 'default min_size for any created local pool',
-            'runtime': True,
-        },
-        {
-            'name': 'num_rep',
-            'type': 'int',
-            'default': 3,
-            'desc': 'default replica count for any created local pool',
-            'runtime': True,
-        },
-        {
-            'name': 'pg_num',
-            'type': 'int',
-            'default': 128,
-            'desc': 'default pg_num for any created local pool',
-            'runtime': True,
-        },
-        {
-            'name': 'prefix',
-            'type': 'str',
-            'default': '',
-            'desc': 'name prefix for any created local pool',
-            'runtime': True,
-        },
+        Option(
+            name='subtree',
+            type='str',
+            default='rack',
+            desc='CRUSH level for which to create a local pool',
+            runtime=True),
+        Option(
+            name='failure_domain',
+            type='str',
+            default='host',
+            desc='failure domain for any created local pool',
+            runtime=True),
+        Option(
+            name='min_size',
+            type='int',
+            desc='default min_size for any created local pool',
+            runtime=True),
+        Option(
+            name='num_rep',
+            type='int',
+            default=3,
+            desc='default replica count for any created local pool',
+            runtime=True),
+        Option(
+            name='pg_num',
+            type='int',
+            default=128,
+            desc='default pg_num for any created local pool',
+            runtime=True),
+        Option(
+            name='prefix',
+            type='str',
+            default='',
+            desc='name prefix for any created local pool',
+            runtime=True),
     ]
 
     def __init__(self, *args, **kwargs):