mds: MDS-MDS message classes inherit from MMDSOp

Fixes: https://tracker.ceph.com/issues/41565
Signed-off-by: Jos Collin <jcollin@redhat.com>

diff --git a/src/messages/MCacheExpire.h b/src/messages/MCacheExpire.h
index 8cd5d796a82b452e323442f0e9e2f32964714106..aea1aa811e43ea167b6a86406d481b91219aadd7 100644 (file)
--- a/src/messages/MCacheExpire.h
+++ b/src/messages/MCacheExpire.h
@@ -16,12 +16,10 @@
 #define CEPH_MCACHEEXPIRE_H
 
 #include <string_view>
-
-#include "msg/Message.h"
-
 #include "mds/mdstypes.h"
+#include "messages/MMDSOp.h"
 
-class MCacheExpire : public SafeMessage {
+class MCacheExpire : public MMDSOp {
 private:
   __s32 from;
 
@@ -66,9 +64,9 @@ public:
   int get_from() const { return from; }
 
 protected:
-  MCacheExpire() : SafeMessage{MSG_MDS_CACHEEXPIRE}, from(-1) {}
+  MCacheExpire() : MMDSOp{MSG_MDS_CACHEEXPIRE}, from(-1) {}
   MCacheExpire(int f) :
-    SafeMessage{MSG_MDS_CACHEEXPIRE},
+    MMDSOp{MSG_MDS_CACHEEXPIRE},
     from(f) { }
   ~MCacheExpire() override {}
 

diff --git a/src/messages/MClientRequest.h b/src/messages/MClientRequest.h
index 204f1e7119784a7207ee8800c9ef2cde8a12bbf1..135958a76043894c2cb4094142110efe67b01755 100644 (file)
--- a/src/messages/MClientRequest.h
+++ b/src/messages/MClientRequest.h
@@ -35,10 +35,10 @@
 
 #include <string_view>
 
-#include "msg/Message.h"
 #include "include/filepath.h"
 #include "mds/mdstypes.h"
 #include "include/ceph_features.h"
+#include "messages/MMDSOp.h"
 
 #include <sys/types.h>
 #include <utime.h>
@@ -48,7 +48,7 @@
 
 // metadata ops.
 
-class MClientRequest : public SafeMessage {
+class MClientRequest : public MMDSOp {
 private:
   static constexpr int HEAD_VERSION = 4;
   static constexpr int COMPAT_VERSION = 1;
@@ -89,9 +89,9 @@ public:
 protected:
   // cons
   MClientRequest()
-    : SafeMessage(CEPH_MSG_CLIENT_REQUEST, HEAD_VERSION, COMPAT_VERSION) {}
+    : MMDSOp(CEPH_MSG_CLIENT_REQUEST, HEAD_VERSION, COMPAT_VERSION) {}
   MClientRequest(int op)
-    : SafeMessage(CEPH_MSG_CLIENT_REQUEST, HEAD_VERSION, COMPAT_VERSION) {
+    : MMDSOp(CEPH_MSG_CLIENT_REQUEST, HEAD_VERSION, COMPAT_VERSION) {
     memset(&head, 0, sizeof(head));
     head.op = op;
   }

diff --git a/src/messages/MDentryLink.h b/src/messages/MDentryLink.h
index 5a1ce9c4e6f633df6655dac8759214df626d9b1c..dded32ed2325b5c17f359f6624264261b84fb2f3 100644 (file)
--- a/src/messages/MDentryLink.h
+++ b/src/messages/MDentryLink.h
@@ -18,12 +18,12 @@
 
 #include <string_view>
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MDentryLink : public SafeMessage {
+class MDentryLink : public MMDSOp {
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
   
   dirfrag_t subtree;
   dirfrag_t dirfrag;
@@ -40,9 +40,9 @@ private:
 
 protected:
   MDentryLink() :
-    SafeMessage(MSG_MDS_DENTRYLINK, HEAD_VERSION, COMPAT_VERSION) { }
+    MMDSOp(MSG_MDS_DENTRYLINK, HEAD_VERSION, COMPAT_VERSION) { }
   MDentryLink(dirfrag_t r, dirfrag_t df, std::string_view n, bool p) :
-    SafeMessage(MSG_MDS_DENTRYLINK, HEAD_VERSION, COMPAT_VERSION),
+    MMDSOp(MSG_MDS_DENTRYLINK, HEAD_VERSION, COMPAT_VERSION),
     subtree(r),
     dirfrag(df),
     dn(n),

diff --git a/src/messages/MDentryUnlink.h b/src/messages/MDentryUnlink.h
index 3037acec43f8aea9db77670055053a2c7c66df33..27b46079f5340b8429e76e3b3bf4141630205c04 100644 (file)
--- a/src/messages/MDentryUnlink.h
+++ b/src/messages/MDentryUnlink.h
@@ -18,12 +18,12 @@
 
 #include <string_view>
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MDentryUnlink : public SafeMessage {
+class MDentryUnlink : public MMDSOp {
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
   
   dirfrag_t dirfrag;
   std::string dn;
@@ -37,9 +37,9 @@ private:
 
 protected:
   MDentryUnlink() :
-    SafeMessage(MSG_MDS_DENTRYUNLINK, HEAD_VERSION, COMPAT_VERSION) { }
+    MMDSOp(MSG_MDS_DENTRYUNLINK, HEAD_VERSION, COMPAT_VERSION) { }
   MDentryUnlink(dirfrag_t df, std::string_view n) :
-    SafeMessage(MSG_MDS_DENTRYUNLINK, HEAD_VERSION, COMPAT_VERSION),
+    MMDSOp(MSG_MDS_DENTRYUNLINK, HEAD_VERSION, COMPAT_VERSION),
     dirfrag(df),
     dn(n) {}
   ~MDentryUnlink() override {}

diff --git a/src/messages/MDirUpdate.h b/src/messages/MDirUpdate.h
index 8a2629f19c2f5bac740a2e536b8212d3ed28d328..468d4a0b5cb1e7ffac11c0bb504c11229dd2e104 100644 (file)
--- a/src/messages/MDirUpdate.h
+++ b/src/messages/MDirUpdate.h
@@ -16,9 +16,9 @@
 #ifndef CEPH_MDIRUPDATE_H
 #define CEPH_MDIRUPDATE_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MDirUpdate : public SafeMessage {
+class MDirUpdate : public MMDSOp {
 public:
   mds_rank_t get_source_mds() const { return from_mds; }
   dirfrag_t get_dirfrag() const { return dirfrag; }
@@ -58,19 +58,19 @@ public:
 
 protected:
   ~MDirUpdate() {}
-  MDirUpdate() : SafeMessage(MSG_MDS_DIRUPDATE, HEAD_VERSION, COMPAT_VERSION) {}
+  MDirUpdate() : MMDSOp(MSG_MDS_DIRUPDATE, HEAD_VERSION, COMPAT_VERSION) {}
   MDirUpdate(mds_rank_t f,
             dirfrag_t dirfrag,
              int dir_rep,
              const std::set<int32_t>& dir_rep_by,
              filepath& path,
              bool discover = false) :
-    SafeMessage(MSG_MDS_DIRUPDATE, HEAD_VERSION, COMPAT_VERSION), from_mds(f), dirfrag(dirfrag),
+    MMDSOp(MSG_MDS_DIRUPDATE, HEAD_VERSION, COMPAT_VERSION), from_mds(f), dirfrag(dirfrag),
     dir_rep(dir_rep), dir_rep_by(dir_rep_by), path(path) {
     this->discover = discover ? 5 : 0;
   }
   MDirUpdate(const MDirUpdate& m)
-  : SafeMessage{MSG_MDS_DIRUPDATE},
+  : MMDSOp{MSG_MDS_DIRUPDATE},
     from_mds(m.from_mds),
     dirfrag(m.dirfrag),
     dir_rep(m.dir_rep),
@@ -89,8 +89,8 @@ protected:
   mutable int tried_discover = 0; // XXX HACK
 
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
   template<class T, typename... Args>
   friend boost::intrusive_ptr<T> ceph::make_message(Args&&... args);
 };

diff --git a/src/messages/MDiscover.h b/src/messages/MDiscover.h
index c821d7bfc6aa558756db28ffe2353dc8186afbb3..d6d14ad692a1b8f32b3e8b4736fb2d85e6e25b2f 100644 (file)
--- a/src/messages/MDiscover.h
+++ b/src/messages/MDiscover.h
@@ -16,13 +16,13 @@
 #ifndef CEPH_MDISCOVER_H
 #define CEPH_MDISCOVER_H
 
-#include "msg/Message.h"
 #include "include/filepath.h"
+#include "messages/MMDSOp.h"
 
 #include <string>
 
 
-class MDiscover : public SafeMessage {
+class MDiscover : public MMDSOp {
 private:
   static constexpr int HEAD_VERSION = 1;
   static constexpr int COMPAT_VERSION = 1;
@@ -50,14 +50,14 @@ private:
   void set_base_dir_frag(frag_t f) { base_dir_frag = f; }
 
 protected:
-  MDiscover() : SafeMessage(MSG_MDS_DISCOVER, HEAD_VERSION, COMPAT_VERSION) { }
+  MDiscover() : MMDSOp(MSG_MDS_DISCOVER, HEAD_VERSION, COMPAT_VERSION) { }
   MDiscover(inodeno_t base_ino_,
            frag_t base_frag_,
            snapid_t s,
             filepath& want_path_,
             bool want_base_dir_ = true,
            bool path_locked_ = false) :
-    SafeMessage{MSG_MDS_DISCOVER},
+    MMDSOp{MSG_MDS_DISCOVER},
     base_ino(base_ino_),
     base_dir_frag(base_frag_),
     snapid(s),

diff --git a/src/messages/MDiscoverReply.h b/src/messages/MDiscoverReply.h
index 7a491406bd75614a733e8ec4a9213647c4744e72..f14c156c69998d63aefdb19c14d874e70577140d 100644 (file)
--- a/src/messages/MDiscoverReply.h
+++ b/src/messages/MDiscoverReply.h
@@ -16,8 +16,8 @@
 #ifndef CEPH_MDISCOVERREPLY_H
 #define CEPH_MDISCOVERREPLY_H
 
-#include "msg/Message.h"
 #include "include/filepath.h"
+#include "messages/MMDSOp.h"
 
 #include <string>
 
@@ -63,7 +63,7 @@
  * 
  */
 
-class MDiscoverReply : public SafeMessage {
+class MDiscoverReply : public MMDSOp {
 private:
   static constexpr int HEAD_VERSION = 2;
   static constexpr int COMPAT_VERSION = 2;
@@ -110,9 +110,9 @@ private:
   void set_base_dir_frag(frag_t df) { base_dir_frag = df; }
 
 protected:
-  MDiscoverReply() : SafeMessage{MSG_MDS_DISCOVERREPLY, HEAD_VERSION, COMPAT_VERSION} { }
+  MDiscoverReply() : MMDSOp{MSG_MDS_DISCOVERREPLY, HEAD_VERSION, COMPAT_VERSION} { }
   MDiscoverReply(const MDiscover &dis) :
-    SafeMessage{MSG_MDS_DISCOVERREPLY, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_DISCOVERREPLY, HEAD_VERSION, COMPAT_VERSION},
     base_ino(dis.get_base_ino()),
     base_dir_frag(dis.get_base_dir_frag()),
     wanted_base_dir(dis.wants_base_dir()),
@@ -127,7 +127,7 @@ protected:
     header.tid = dis.get_tid();
   }
   MDiscoverReply(dirfrag_t df) :
-    SafeMessage{MSG_MDS_DISCOVERREPLY, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_DISCOVERREPLY, HEAD_VERSION, COMPAT_VERSION},
     base_ino(df.ino),
     base_dir_frag(df.frag),
     wanted_base_dir(false),

diff --git a/src/messages/MExportCaps.h b/src/messages/MExportCaps.h
index d37851b8783c18f98d3a134cfb1197a5d334fc79..1c989a3e66f5895ae1fb22a0d04b802e1278f0e9 100644 (file)
--- a/src/messages/MExportCaps.h
+++ b/src/messages/MExportCaps.h
@@ -16,10 +16,9 @@
 #ifndef CEPH_MEXPORTCAPS_H
 #define CEPH_MEXPORTCAPS_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-
-class MExportCaps : public SafeMessage {
+class MExportCaps : public MMDSOp {
 private:
   static constexpr int HEAD_VERSION = 2;
   static constexpr int COMPAT_VERSION = 1;
@@ -32,7 +31,7 @@ public:
 
 protected:
   MExportCaps() :
-    SafeMessage{MSG_MDS_EXPORTCAPS, HEAD_VERSION, COMPAT_VERSION} {}
+    MMDSOp{MSG_MDS_EXPORTCAPS, HEAD_VERSION, COMPAT_VERSION} {}
   ~MExportCaps() override {}
 
 public:

diff --git a/src/messages/MExportCapsAck.h b/src/messages/MExportCapsAck.h
index f5505cdb3653bb37f37e3ffdc06c6136d6429530..6e9debc4eb60c560238248a9b2ee11e63ecde117 100644 (file)
--- a/src/messages/MExportCapsAck.h
+++ b/src/messages/MExportCapsAck.h
@@ -16,10 +16,9 @@
 #ifndef CEPH_MEXPORTCAPSACK_H
 #define CEPH_MEXPORTCAPSACK_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-
-class MExportCapsAck : public SafeMessage {
+class MExportCapsAck : public MMDSOp {
  static constexpr int HEAD_VERSION = 1;
  static constexpr int COMPAT_VERSION = 1;
 
@@ -29,9 +28,9 @@ public:
 
 protected:
   MExportCapsAck() :
-    SafeMessage{MSG_MDS_EXPORTCAPSACK, HEAD_VERSION, COMPAT_VERSION} {}
+    MMDSOp{MSG_MDS_EXPORTCAPSACK, HEAD_VERSION, COMPAT_VERSION} {}
   MExportCapsAck(inodeno_t i) :
-    SafeMessage{MSG_MDS_EXPORTCAPSACK, HEAD_VERSION, COMPAT_VERSION}, ino(i) {}
+    MMDSOp{MSG_MDS_EXPORTCAPSACK, HEAD_VERSION, COMPAT_VERSION}, ino(i) {}
   ~MExportCapsAck() override {}
 
 public:

diff --git a/src/messages/MExportDir.h b/src/messages/MExportDir.h
index f2663015b859fc5c92df203c41c312e8a1d07b2d..dd2f535273bab6d7cf77cab009593e743281b2eb 100644 (file)
--- a/src/messages/MExportDir.h
+++ b/src/messages/MExportDir.h
@@ -16,10 +16,9 @@
 #ifndef CEPH_MEXPORTDIR_H
 #define CEPH_MEXPORTDIR_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-
-class MExportDir : public SafeMessage {
+class MExportDir : public MMDSOp {
 public:
   dirfrag_t dirfrag;
   ceph::buffer::list export_data;
@@ -27,9 +26,9 @@ public:
   ceph::buffer::list client_map;
 
 protected:
-  MExportDir() : SafeMessage{MSG_MDS_EXPORTDIR} {}
+  MExportDir() : MMDSOp{MSG_MDS_EXPORTDIR} {}
   MExportDir(dirfrag_t df, uint64_t tid) :
-    SafeMessage{MSG_MDS_EXPORTDIR}, dirfrag(df) {
+    MMDSOp{MSG_MDS_EXPORTDIR}, dirfrag(df) {
     set_tid(tid);
   }
   ~MExportDir() override {}

diff --git a/src/messages/MExportDirAck.h b/src/messages/MExportDirAck.h
index fcbd09ad9cf908e984eef13031081179a6fbad87..0ff131921f9ebabf58919e68ee681e7a1228c547 100644 (file)
--- a/src/messages/MExportDirAck.h
+++ b/src/messages/MExportDirAck.h
@@ -16,9 +16,9 @@
 #define CEPH_MEXPORTDIRACK_H
 
 #include "MExportDir.h"
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MExportDirAck : public SafeMessage {
+class MExportDirAck : public MMDSOp {
 public:
   dirfrag_t dirfrag;
   ceph::buffer::list imported_caps;
@@ -26,9 +26,9 @@ public:
   dirfrag_t get_dirfrag() const { return dirfrag; }
   
 protected:
-  MExportDirAck() : SafeMessage{MSG_MDS_EXPORTDIRACK} {}
+  MExportDirAck() : MMDSOp{MSG_MDS_EXPORTDIRACK} {}
   MExportDirAck(dirfrag_t df, uint64_t tid) :
-    SafeMessage{MSG_MDS_EXPORTDIRACK}, dirfrag(df) {
+    MMDSOp{MSG_MDS_EXPORTDIRACK}, dirfrag(df) {
     set_tid(tid);
   }
   ~MExportDirAck() override {}

diff --git a/src/messages/MExportDirCancel.h b/src/messages/MExportDirCancel.h
index df14a134c4580b5107d29bcda01ace33b9e2a06a..5c35b449b4924487849af4db5b08eea8d3cc14fe 100644 (file)
--- a/src/messages/MExportDirCancel.h
+++ b/src/messages/MExportDirCancel.h
@@ -15,22 +15,22 @@
 #ifndef CEPH_MEXPORTDIRCANCEL_H
 #define CEPH_MEXPORTDIRCANCEL_H
 
-#include "msg/Message.h"
 #include "include/types.h"
+#include "messages/MMDSOp.h"
 
-class MExportDirCancel : public SafeMessage {
+class MExportDirCancel : public MMDSOp {
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
   dirfrag_t dirfrag;
 
  public:
   dirfrag_t get_dirfrag() const { return dirfrag; }
 
 protected:
-  MExportDirCancel() : SafeMessage{MSG_MDS_EXPORTDIRCANCEL, HEAD_VERSION, COMPAT_VERSION} {}
+  MExportDirCancel() : MMDSOp{MSG_MDS_EXPORTDIRCANCEL, HEAD_VERSION, COMPAT_VERSION} {}
   MExportDirCancel(dirfrag_t df, uint64_t tid) :
-    SafeMessage{MSG_MDS_EXPORTDIRCANCEL, HEAD_VERSION, COMPAT_VERSION}, dirfrag(df) {
+    MMDSOp{MSG_MDS_EXPORTDIRCANCEL, HEAD_VERSION, COMPAT_VERSION}, dirfrag(df) {
     set_tid(tid);
   }
   ~MExportDirCancel() override {}

diff --git a/src/messages/MExportDirDiscover.h b/src/messages/MExportDirDiscover.h
index 62d9a1481e12136b202994f75137fd05638a3fa6..90022a7642986e2a1045618f6ba89a1d23892cba 100644 (file)
--- a/src/messages/MExportDirDiscover.h
+++ b/src/messages/MExportDirDiscover.h
@@ -15,13 +15,13 @@
 #ifndef CEPH_MEXPORTDIRDISCOVER_H
 #define CEPH_MEXPORTDIRDISCOVER_H
 
-#include "msg/Message.h"
 #include "include/types.h"
+#include "messages/MMDSOp.h"
 
-class MExportDirDiscover : public SafeMessage {
+class MExportDirDiscover : public MMDSOp {
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
   mds_rank_t from = -1;
   dirfrag_t dirfrag;
   filepath path;
@@ -36,10 +36,10 @@ private:
 
 protected:
   MExportDirDiscover() :     
-    SafeMessage{MSG_MDS_EXPORTDIRDISCOVER, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_EXPORTDIRDISCOVER, HEAD_VERSION, COMPAT_VERSION},
     started(false) { }
   MExportDirDiscover(dirfrag_t df, filepath& p, mds_rank_t f, uint64_t tid) :
-    SafeMessage{MSG_MDS_EXPORTDIRDISCOVER, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_EXPORTDIRDISCOVER, HEAD_VERSION, COMPAT_VERSION},
     from(f), dirfrag(df), path(p), started(false) {
     set_tid(tid);
   }

diff --git a/src/messages/MExportDirDiscoverAck.h b/src/messages/MExportDirDiscoverAck.h
index f5f77de75a8089bb676a43152488f0cb86758402..c89a7e65d0c997d59057e628b4b9100ea9e73305 100644 (file)
--- a/src/messages/MExportDirDiscoverAck.h
+++ b/src/messages/MExportDirDiscoverAck.h
@@ -15,13 +15,13 @@
 #ifndef CEPH_MEXPORTDIRDISCOVERACK_H
 #define CEPH_MEXPORTDIRDISCOVERACK_H
 
-#include "msg/Message.h"
 #include "include/types.h"
+#include "messages/MMDSOp.h"
 
-class MExportDirDiscoverAck : public SafeMessage {
+class MExportDirDiscoverAck : public MMDSOp {
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 
   dirfrag_t dirfrag;
   bool success;
@@ -32,9 +32,9 @@ private:
   bool is_success() const { return success; }
 
 protected:
-  MExportDirDiscoverAck() : SafeMessage{MSG_MDS_EXPORTDIRDISCOVERACK, HEAD_VERSION, COMPAT_VERSION} {}
+  MExportDirDiscoverAck() : MMDSOp{MSG_MDS_EXPORTDIRDISCOVERACK, HEAD_VERSION, COMPAT_VERSION} {}
   MExportDirDiscoverAck(dirfrag_t df, uint64_t tid, bool s=true) :
-    SafeMessage{MSG_MDS_EXPORTDIRDISCOVERACK, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_EXPORTDIRDISCOVERACK, HEAD_VERSION, COMPAT_VERSION},
     dirfrag(df), success(s) {
     set_tid(tid);
   }

diff --git a/src/messages/MExportDirFinish.h b/src/messages/MExportDirFinish.h
index d9e216759e013b4848e6b4da7653fc172dbc9666..22272d703d4dbca5482b9249b99f5cbce41f1ea1 100644 (file)
--- a/src/messages/MExportDirFinish.h
+++ b/src/messages/MExportDirFinish.h
@@ -15,12 +15,12 @@
 #ifndef CEPH_MEXPORTDIRFINISH_H
 #define CEPH_MEXPORTDIRFINISH_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MExportDirFinish : public SafeMessage {
+class MExportDirFinish : public MMDSOp {
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 
   dirfrag_t dirfrag;
   bool last;
@@ -31,9 +31,9 @@ private:
   
 protected:
   MExportDirFinish() :
-    SafeMessage{MSG_MDS_EXPORTDIRFINISH, HEAD_VERSION, COMPAT_VERSION}, last(false) {}
+    MMDSOp{MSG_MDS_EXPORTDIRFINISH, HEAD_VERSION, COMPAT_VERSION}, last(false) {}
   MExportDirFinish(dirfrag_t df, bool l, uint64_t tid) :
-    SafeMessage{MSG_MDS_EXPORTDIRFINISH, HEAD_VERSION, COMPAT_VERSION}, dirfrag(df), last(l) {
+    MMDSOp{MSG_MDS_EXPORTDIRFINISH, HEAD_VERSION, COMPAT_VERSION}, dirfrag(df), last(l) {
     set_tid(tid);
   }
   ~MExportDirFinish() override {}

diff --git a/src/messages/MExportDirNotify.h b/src/messages/MExportDirNotify.h
index 5419529589e14d84162b7189770c5b02bc3008e1..7245abe26d9ab4e8bc58a96290312125900f3c8a 100644 (file)
--- a/src/messages/MExportDirNotify.h
+++ b/src/messages/MExportDirNotify.h
@@ -15,12 +15,12 @@
 #ifndef CEPH_MEXPORTDIRNOTIFY_H
 #define CEPH_MEXPORTDIRNOTIFY_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MExportDirNotify : public SafeMessage {
+class MExportDirNotify : public MMDSOp {
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 
   dirfrag_t base;
   bool ack;
@@ -37,10 +37,10 @@ private:
 
 protected:
   MExportDirNotify() :
-    SafeMessage{MSG_MDS_EXPORTDIRNOTIFY, HEAD_VERSION, COMPAT_VERSION} {}
+    MMDSOp{MSG_MDS_EXPORTDIRNOTIFY, HEAD_VERSION, COMPAT_VERSION} {}
   MExportDirNotify(dirfrag_t i, uint64_t tid, bool a, std::pair<__s32,__s32> oa,
                   std::pair<__s32,__s32> na) :
-    SafeMessage{MSG_MDS_EXPORTDIRNOTIFY, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_EXPORTDIRNOTIFY, HEAD_VERSION, COMPAT_VERSION},
     base(i), ack(a), old_auth(oa), new_auth(na) {
     set_tid(tid);
   }

diff --git a/src/messages/MExportDirNotifyAck.h b/src/messages/MExportDirNotifyAck.h
index f9e4a98b010889efa7b00b5d28bd89e0bf32772f..d97a109113aaa498e0a5dd143cfa3f7d0536332d 100644 (file)
--- a/src/messages/MExportDirNotifyAck.h
+++ b/src/messages/MExportDirNotifyAck.h
@@ -15,12 +15,12 @@
 #ifndef CEPH_MEXPORTDIRNOTIFYACK_H
 #define CEPH_MEXPORTDIRNOTIFYACK_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MExportDirNotifyAck : public SafeMessage {
+class MExportDirNotifyAck : public MMDSOp {
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 
   dirfrag_t dirfrag;
   std::pair<__s32,__s32> new_auth;
@@ -31,9 +31,9 @@ private:
   
 protected:
   MExportDirNotifyAck() :
-    SafeMessage{MSG_MDS_EXPORTDIRNOTIFYACK, HEAD_VERSION, COMPAT_VERSION} {}
+    MMDSOp{MSG_MDS_EXPORTDIRNOTIFYACK, HEAD_VERSION, COMPAT_VERSION} {}
   MExportDirNotifyAck(dirfrag_t df, uint64_t tid, std::pair<__s32,__s32> na) :
-    SafeMessage{MSG_MDS_EXPORTDIRNOTIFYACK, HEAD_VERSION, COMPAT_VERSION}, dirfrag(df), new_auth(na) {
+    MMDSOp{MSG_MDS_EXPORTDIRNOTIFYACK, HEAD_VERSION, COMPAT_VERSION}, dirfrag(df), new_auth(na) {
     set_tid(tid);
   }
   ~MExportDirNotifyAck() override {}

diff --git a/src/messages/MExportDirPrep.h b/src/messages/MExportDirPrep.h
index e390b748e016354875d7b63610a54cf15547c9bf..4c8d8fc45f7595162da44b4d0ec470af51555416 100644 (file)
--- a/src/messages/MExportDirPrep.h
+++ b/src/messages/MExportDirPrep.h
@@ -16,13 +16,13 @@
 #ifndef CEPH_MEXPORTDIRPREP_H
 #define CEPH_MEXPORTDIRPREP_H
 
-#include "msg/Message.h"
 #include "include/types.h"
+#include "messages/MMDSOp.h"
 
-class MExportDirPrep : public SafeMessage {
+class MExportDirPrep : public MMDSOp {
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 
   dirfrag_t dirfrag;
 public:
@@ -44,7 +44,7 @@ public:
 protected:
   MExportDirPrep() = default;
   MExportDirPrep(dirfrag_t df, uint64_t tid) :
-    SafeMessage{MSG_MDS_EXPORTDIRPREP, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_EXPORTDIRPREP, HEAD_VERSION, COMPAT_VERSION},
     dirfrag(df)
   {
     set_tid(tid);

diff --git a/src/messages/MExportDirPrepAck.h b/src/messages/MExportDirPrepAck.h
index e4f036e689831514fdb505cd411fcfd4ec7bfe5b..eec2ad9bb79c6ba0c34ef9518db8b7980204141e 100644 (file)
--- a/src/messages/MExportDirPrepAck.h
+++ b/src/messages/MExportDirPrepAck.h
@@ -15,13 +15,13 @@
 #ifndef CEPH_MEXPORTDIRPREPACK_H
 #define CEPH_MEXPORTDIRPREPACK_H
 
-#include "msg/Message.h"
 #include "include/types.h"
+#include "messages/MMDSOp.h"
 
-class MExportDirPrepAck : public SafeMessage {
+class MExportDirPrepAck : public MMDSOp {
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 
   dirfrag_t dirfrag;
   bool success = false;
@@ -31,9 +31,9 @@ private:
 
 protected:
   MExportDirPrepAck() :
-    SafeMessage{MSG_MDS_EXPORTDIRPREPACK, HEAD_VERSION, COMPAT_VERSION} {}
+    MMDSOp{MSG_MDS_EXPORTDIRPREPACK, HEAD_VERSION, COMPAT_VERSION} {}
   MExportDirPrepAck(dirfrag_t df, bool s, uint64_t tid) :
-    SafeMessage{MSG_MDS_EXPORTDIRPREPACK, HEAD_VERSION, COMPAT_VERSION}, dirfrag(df), success(s) {
+    MMDSOp{MSG_MDS_EXPORTDIRPREPACK, HEAD_VERSION, COMPAT_VERSION}, dirfrag(df), success(s) {
     set_tid(tid);
   }
   ~MExportDirPrepAck() override {}

diff --git a/src/messages/MGatherCaps.h b/src/messages/MGatherCaps.h
index e1dbcba8c46680d536d1c5ca03d1aa63a06eb33d..2e0dcd7172474508e4c96ca683cd5201e936fa6f 100644 (file)
--- a/src/messages/MGatherCaps.h
+++ b/src/messages/MGatherCaps.h
@@ -1,10 +1,10 @@
 #ifndef CEPH_MGATHERCAPS_H
 #define CEPH_MGATHERCAPS_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
 
-class MGatherCaps : public Message {
+class MGatherCaps : public MMDSOp {
   static constexpr int HEAD_VERSION = 1;
   static constexpr int COMPAT_VERSION = 1;
 
@@ -13,7 +13,7 @@ public:
 
 protected:
   MGatherCaps() :
-    Message{MSG_MDS_GATHERCAPS, HEAD_VERSION, COMPAT_VERSION} {}
+    MMDSOp{MSG_MDS_GATHERCAPS, HEAD_VERSION, COMPAT_VERSION} {}
   ~MGatherCaps() override {}
 
 public:

diff --git a/src/messages/MHeartbeat.h b/src/messages/MHeartbeat.h
index a4d3d3baa8b98edbadd840fa25a2b069e83a8415..d27406fe316b2555749e1dd901a3f06195fb38fe 100644 (file)
--- a/src/messages/MHeartbeat.h
+++ b/src/messages/MHeartbeat.h
@@ -17,10 +17,10 @@
 #define CEPH_MHEARTBEAT_H
 
 #include "include/types.h"
-#include "msg/Message.h"
 #include "common/DecayCounter.h"
+#include "messages/MMDSOp.h"
 
-class MHeartbeat : public Message {
+class MHeartbeat : public MMDSOp {
 private:
   mds_load_t load;
   __s32 beat = 0;
@@ -34,9 +34,9 @@ private:
   std::map<mds_rank_t, float>& get_import_map() { return import_map; }
 
 protected:
-  MHeartbeat() : Message(MSG_MDS_HEARTBEAT), load(DecayRate()) {}
+  MHeartbeat() : MMDSOp(MSG_MDS_HEARTBEAT), load(DecayRate()) {}
   MHeartbeat(mds_load_t& load, int beat)
-    : Message(MSG_MDS_HEARTBEAT),
+    : MMDSOp(MSG_MDS_HEARTBEAT),
       load(load),
       beat(beat)
   {}

diff --git a/src/messages/MInodeFileCaps.h b/src/messages/MInodeFileCaps.h
index bd96489ac7d2d695eb0f6bde6b68ae0c6da8a3af..6841d0fa8a0bac45f48add80d225fdd9a54bc9f9 100644 (file)
--- a/src/messages/MInodeFileCaps.h
+++ b/src/messages/MInodeFileCaps.h
@@ -16,9 +16,9 @@
 #ifndef CEPH_MINODEFILECAPS_H
 #define CEPH_MINODEFILECAPS_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MInodeFileCaps : public SafeMessage {
+class MInodeFileCaps : public MMDSOp {
 private:
   static constexpr int HEAD_VERSION = 1;
   static constexpr int COMPAT_VERSION = 1;
@@ -30,9 +30,9 @@ public:
   int       get_caps() const { return caps; }
 
 protected:
-  MInodeFileCaps() : SafeMessage(MSG_MDS_INODEFILECAPS, HEAD_VERSION, COMPAT_VERSION) {}
+  MInodeFileCaps() : MMDSOp(MSG_MDS_INODEFILECAPS, HEAD_VERSION, COMPAT_VERSION) {}
   MInodeFileCaps(inodeno_t ino, int caps) :
-    SafeMessage(MSG_MDS_INODEFILECAPS, HEAD_VERSION, COMPAT_VERSION) {
+    MMDSOp(MSG_MDS_INODEFILECAPS, HEAD_VERSION, COMPAT_VERSION) {
     this->ino = ino;
     this->caps = caps;
   }

diff --git a/src/messages/MLock.h b/src/messages/MLock.h
index e1ac38ba951c38cb83e9f3154c87f55f207f9095..dc3142d13d29b32526a14cfcaf960e25b9a95523 100644 (file)
--- a/src/messages/MLock.h
+++ b/src/messages/MLock.h
@@ -16,14 +16,14 @@
 #ifndef CEPH_MLOCK_H
 #define CEPH_MLOCK_H
 
-#include "msg/Message.h"
 #include "mds/locks.h"
 #include "mds/SimpleLock.h"
+#include "messages/MMDSOp.h"
 
-class MLock : public SafeMessage {
+class MLock : public MMDSOp {
 private:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 
   int32_t     action = 0;  // action type
   mds_rank_t  asker = 0;  // who is initiating this request
@@ -46,19 +46,19 @@ public:
   MDSCacheObjectInfo &get_object_info() { return object_info; }
 
 protected:
-  MLock() : SafeMessage{MSG_MDS_LOCK, HEAD_VERSION, COMPAT_VERSION} {}
+  MLock() : MMDSOp{MSG_MDS_LOCK, HEAD_VERSION, COMPAT_VERSION} {}
   MLock(int ac, mds_rank_t as) :
-    SafeMessage{MSG_MDS_LOCK, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_LOCK, HEAD_VERSION, COMPAT_VERSION},
     action(ac), asker(as),
     lock_type(0) { }
   MLock(SimpleLock *lock, int ac, mds_rank_t as) :
-    SafeMessage{MSG_MDS_LOCK, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_LOCK, HEAD_VERSION, COMPAT_VERSION},
     action(ac), asker(as),
     lock_type(lock->get_type()) {
     lock->get_parent()->set_object_info(object_info);
   }
   MLock(SimpleLock *lock, int ac, mds_rank_t as, ceph::buffer::list& bl) :
-    SafeMessage{MSG_MDS_LOCK, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_LOCK, HEAD_VERSION, COMPAT_VERSION},
     action(ac), asker(as), lock_type(lock->get_type()) {
     lock->get_parent()->set_object_info(object_info);
     lockdata.claim(bl);

diff --git a/src/messages/MMDSCacheRejoin.h b/src/messages/MMDSCacheRejoin.h
index fba8faf3b71ca199c16bfcec5bc3522e6f9732ba..b0a87af1e3b00b7f884ee114abcd490e2113fc67 100644 (file)
--- a/src/messages/MMDSCacheRejoin.h
+++ b/src/messages/MMDSCacheRejoin.h
@@ -16,18 +16,15 @@
 #define CEPH_MMDSCACHEREJOIN_H
 
 #include <string_view>
-
-#include "msg/Message.h"
-
 #include "include/types.h"
-
 #include "mds/CInode.h"
 #include "mds/CDir.h"
 #include "mds/mdstypes.h"
+#include "messages/MMDSOp.h"
 
 // sent from replica to auth
 
-class MMDSCacheRejoin : public SafeMessage {
+class MMDSCacheRejoin : public MMDSOp {
 public:
   static constexpr int OP_WEAK    = 1;  // replica -> auth, i exist, + maybe open files.
   static constexpr int OP_STRONG  = 2;  // replica -> auth, i exist, + open files and lock state.
@@ -348,7 +345,7 @@ private:
   static constexpr int COMPAT_VERSION = 1;
 
   MMDSCacheRejoin(int o) : MMDSCacheRejoin() { op = o; }
-  MMDSCacheRejoin() : SafeMessage{MSG_MDS_CACHEREJOIN, HEAD_VERSION, COMPAT_VERSION} {}
+  MMDSCacheRejoin() : MMDSOp{MSG_MDS_CACHEREJOIN, HEAD_VERSION, COMPAT_VERSION} {}
   ~MMDSCacheRejoin() override {}
 };
 

diff --git a/src/messages/MMDSFindIno.h b/src/messages/MMDSFindIno.h
index 6bc5e01204fa7963c3604a24bae23378ead1512c..a8845a62baa508b1450f3e48c2b04fce7ffaad34 100644 (file)
--- a/src/messages/MMDSFindIno.h
+++ b/src/messages/MMDSFindIno.h
@@ -15,19 +15,19 @@
 #ifndef CEPH_MDSFINDINO_H
 #define CEPH_MDSFINDINO_H
 
-#include "msg/Message.h"
 #include "include/filepath.h"
+#include "messages/MMDSOp.h"
 
-class MMDSFindIno : public SafeMessage {
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+class MMDSFindIno : public MMDSOp {
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 public:
   ceph_tid_t tid {0};
   inodeno_t ino;
 
 protected:
-  MMDSFindIno() : SafeMessage{MSG_MDS_FINDINO, HEAD_VERSION, COMPAT_VERSION} {}
-  MMDSFindIno(ceph_tid_t t, inodeno_t i) : SafeMessage{MSG_MDS_FINDINO, HEAD_VERSION, COMPAT_VERSION}, tid(t), ino(i) {}
+  MMDSFindIno() : MMDSOp{MSG_MDS_FINDINO, HEAD_VERSION, COMPAT_VERSION} {}
+  MMDSFindIno(ceph_tid_t t, inodeno_t i) : MMDSOp{MSG_MDS_FINDINO, HEAD_VERSION, COMPAT_VERSION}, tid(t), ino(i) {}
   ~MMDSFindIno() override {}
 
 public:

diff --git a/src/messages/MMDSFindInoReply.h b/src/messages/MMDSFindInoReply.h
index 6747983ff4e170f1fa9ffa3d3d4940117b85402e..c3807ac1045492c8a8c87bbc45bb0e461049c6ad 100644 (file)
--- a/src/messages/MMDSFindInoReply.h
+++ b/src/messages/MMDSFindInoReply.h
@@ -15,19 +15,19 @@
 #ifndef CEPH_MDSFINDINOREPLY_H
 #define CEPH_MDSFINDINOREPLY_H
 
-#include "msg/Message.h"
 #include "include/filepath.h"
+#include "messages/MMDSOp.h"
 
-class MMDSFindInoReply : public SafeMessage {
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+class MMDSFindInoReply : public MMDSOp {
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 public:
   ceph_tid_t tid = 0;
   filepath path;
 
 protected:
-  MMDSFindInoReply() : SafeMessage{MSG_MDS_FINDINOREPLY, HEAD_VERSION, COMPAT_VERSION} {}
-  MMDSFindInoReply(ceph_tid_t t) : SafeMessage{MSG_MDS_FINDINOREPLY, HEAD_VERSION, COMPAT_VERSION}, tid(t) {}
+  MMDSFindInoReply() : MMDSOp{MSG_MDS_FINDINOREPLY, HEAD_VERSION, COMPAT_VERSION} {}
+  MMDSFindInoReply(ceph_tid_t t) : MMDSOp{MSG_MDS_FINDINOREPLY, HEAD_VERSION, COMPAT_VERSION}, tid(t) {}
   ~MMDSFindInoReply() override {}
 
 public:

diff --git a/src/messages/MMDSFragmentNotify.h b/src/messages/MMDSFragmentNotify.h
index cd5e2369895c4a092f6ac2420c30541d58ea1dbc..65d21d40c7cc87790b121de824cdecd3e5d66003 100644 (file)
--- a/src/messages/MMDSFragmentNotify.h
+++ b/src/messages/MMDSFragmentNotify.h
@@ -15,9 +15,9 @@
 #ifndef CEPH_MMDSFRAGMENTNOTIFY_H
 #define CEPH_MMDSFRAGMENTNOTIFY_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MMDSFragmentNotify : public SafeMessage {
+class MMDSFragmentNotify : public MMDSOp {
 private:
   static constexpr int HEAD_VERSION = 2;
   static constexpr int COMPAT_VERSION = 1;
@@ -38,9 +38,9 @@ private:
 
 protected:
   MMDSFragmentNotify() :
-    SafeMessage{MSG_MDS_FRAGMENTNOTIFY, HEAD_VERSION, COMPAT_VERSION} {}
+    MMDSOp{MSG_MDS_FRAGMENTNOTIFY, HEAD_VERSION, COMPAT_VERSION} {}
   MMDSFragmentNotify(dirfrag_t df, int b, uint64_t tid) :
-    SafeMessage{MSG_MDS_FRAGMENTNOTIFY, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_FRAGMENTNOTIFY, HEAD_VERSION, COMPAT_VERSION},
     base_dirfrag(df), bits(b) {
     set_tid(tid);
   }

diff --git a/src/messages/MMDSFragmentNotifyAck.h b/src/messages/MMDSFragmentNotifyAck.h
index 197f965a014f9855c1d25a3a69abb9a919faacd0..ed976c3dd9ff149bd8bcd540ef8f1400a874dc38 100644 (file)
--- a/src/messages/MMDSFragmentNotifyAck.h
+++ b/src/messages/MMDSFragmentNotifyAck.h
@@ -15,9 +15,9 @@
 #ifndef CEPH_MMDSFRAGMENTNOTIFYAck_H
 #define CEPH_MMDSFRAGMENTNOTIFYAck_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MMDSFragmentNotifyAck : public SafeMessage {
+class MMDSFragmentNotifyAck : public MMDSOp {
 private:
   dirfrag_t base_dirfrag;
   int8_t bits = 0;
@@ -29,9 +29,9 @@ private:
   ceph::buffer::list basebl;
 
 protected:
-  MMDSFragmentNotifyAck() : SafeMessage{MSG_MDS_FRAGMENTNOTIFYACK} {}
+  MMDSFragmentNotifyAck() : MMDSOp{MSG_MDS_FRAGMENTNOTIFYACK} {}
   MMDSFragmentNotifyAck(dirfrag_t df, int b, uint64_t tid) :
-    SafeMessage{MSG_MDS_FRAGMENTNOTIFYACK},
+    MMDSOp{MSG_MDS_FRAGMENTNOTIFYACK},
     base_dirfrag(df), bits(b) {
     set_tid(tid);
   }

diff --git a/src/messages/MMDSOpenIno.h b/src/messages/MMDSOpenIno.h
index e49a27429ddaea39727e62f140f9e2227bfd6ba9..e08dd683a5dfaa25641f18d8f44773b8b5eb9fd9 100644 (file)
--- a/src/messages/MMDSOpenIno.h
+++ b/src/messages/MMDSOpenIno.h
@@ -15,19 +15,19 @@
 #ifndef CEPH_MDSOPENINO_H
 #define CEPH_MDSOPENINO_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MMDSOpenIno : public SafeMessage {
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+class MMDSOpenIno : public MMDSOp {
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 public:
   inodeno_t ino;
   std::vector<inode_backpointer_t> ancestors;
 
 protected:
-  MMDSOpenIno() : SafeMessage{MSG_MDS_OPENINO, HEAD_VERSION, COMPAT_VERSION} {}
+  MMDSOpenIno() : MMDSOp{MSG_MDS_OPENINO, HEAD_VERSION, COMPAT_VERSION} {}
   MMDSOpenIno(ceph_tid_t t, inodeno_t i, std::vector<inode_backpointer_t>* pa) :
-    SafeMessage{MSG_MDS_OPENINO, HEAD_VERSION, COMPAT_VERSION}, ino(i) {
+    MMDSOp{MSG_MDS_OPENINO, HEAD_VERSION, COMPAT_VERSION}, ino(i) {
     header.tid = t;
     if (pa)
       ancestors = *pa;

diff --git a/src/messages/MMDSOpenInoReply.h b/src/messages/MMDSOpenInoReply.h
index 5821260d34827d7f18d99d676a9adf043d43e4df..a65bbade3f8967836c28608048b929c534388e1d 100644 (file)
--- a/src/messages/MMDSOpenInoReply.h
+++ b/src/messages/MMDSOpenInoReply.h
@@ -15,21 +15,21 @@
 #ifndef CEPH_MDSOPENINOREPLY_H
 #define CEPH_MDSOPENINOREPLY_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MMDSOpenInoReply : public SafeMessage {
+class MMDSOpenInoReply : public MMDSOp {
 public:
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
   inodeno_t ino;
   std::vector<inode_backpointer_t> ancestors;
   mds_rank_t hint;
   int32_t error;
 
 protected:
-  MMDSOpenInoReply() : SafeMessage{MSG_MDS_OPENINOREPLY, HEAD_VERSION, COMPAT_VERSION}, error(0) {}
+  MMDSOpenInoReply() : MMDSOp{MSG_MDS_OPENINOREPLY, HEAD_VERSION, COMPAT_VERSION}, error(0) {}
   MMDSOpenInoReply(ceph_tid_t t, inodeno_t i, mds_rank_t h=MDS_RANK_NONE, int e=0) :
-    SafeMessage{MSG_MDS_OPENINOREPLY, HEAD_VERSION, COMPAT_VERSION}, ino(i), hint(h), error(e) {
+    MMDSOp{MSG_MDS_OPENINOREPLY, HEAD_VERSION, COMPAT_VERSION}, ino(i), hint(h), error(e) {
     header.tid = t;
   }
 

diff --git a/src/messages/MMDSResolve.h b/src/messages/MMDSResolve.h
index c303b241a7a9f369814632724ac5b9d356378fa4..22add6d02c5a1a053059f25aa67d59e36dab1ac1 100644 (file)
--- a/src/messages/MMDSResolve.h
+++ b/src/messages/MMDSResolve.h
@@ -15,15 +15,13 @@
 #ifndef CEPH_MMDSRESOLVE_H
 #define CEPH_MMDSRESOLVE_H
 
-#include "msg/Message.h"
-
 #include "include/types.h"
-
 #include "mds/Capability.h"
+#include "messages/MMDSOp.h"
 
-class MMDSResolve : public SafeMessage {
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+class MMDSResolve : public MMDSOp {
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 
 public:
   std::map<dirfrag_t, std::vector<dirfrag_t>> subtrees;
@@ -96,7 +94,7 @@ public:
   std::list<table_client> table_clients;
 
 protected:
-  MMDSResolve() : SafeMessage{MSG_MDS_RESOLVE, HEAD_VERSION, COMPAT_VERSION}
+  MMDSResolve() : MMDSOp{MSG_MDS_RESOLVE, HEAD_VERSION, COMPAT_VERSION}
  {}
   ~MMDSResolve() override {}
 

diff --git a/src/messages/MMDSResolveAck.h b/src/messages/MMDSResolveAck.h
index 5e1e4907709529a04216e8a15aae042ba4bd975a..de92d30f8bc04589eaf11c77eff0c89bed82f9ff 100644 (file)
--- a/src/messages/MMDSResolveAck.h
+++ b/src/messages/MMDSResolveAck.h
@@ -15,20 +15,19 @@
 #ifndef CEPH_MMDSRESOLVEACK_H
 #define CEPH_MMDSRESOLVEACK_H
 
-#include "msg/Message.h"
-
 #include "include/types.h"
+#include "messages/MMDSOp.h"
 
 
-class MMDSResolveAck : public SafeMessage {
-  static const int HEAD_VERSION = 1;
-  static const int COMPAT_VERSION = 1;
+class MMDSResolveAck : public MMDSOp {
+  static constexpr int HEAD_VERSION = 1;
+  static constexpr int COMPAT_VERSION = 1;
 public:
   std::map<metareqid_t, ceph::buffer::list> commit;
   std::vector<metareqid_t> abort;
 
 protected:
-  MMDSResolveAck() : SafeMessage{MSG_MDS_RESOLVEACK, HEAD_VERSION, COMPAT_VERSION} {}
+  MMDSResolveAck() : MMDSOp{MSG_MDS_RESOLVEACK, HEAD_VERSION, COMPAT_VERSION} {}
   ~MMDSResolveAck() override {}
 
 public:

diff --git a/src/messages/MMDSSlaveRequest.h b/src/messages/MMDSSlaveRequest.h
index e1aa30aea773bea701cefc2d2003e672a539d5ed..4c1f2a6c287cb50a5de34b3796d1c53fe0823aac 100644 (file)
--- a/src/messages/MMDSSlaveRequest.h
+++ b/src/messages/MMDSSlaveRequest.h
@@ -16,10 +16,10 @@
 #ifndef CEPH_MMDSSLAVEREQUEST_H
 #define CEPH_MMDSSLAVEREQUEST_H
 
-#include "msg/Message.h"
 #include "mds/mdstypes.h"
+#include "messages/MMDSOp.h"
 
-class MMDSSlaveRequest : public SafeMessage {
+class MMDSSlaveRequest : public MMDSOp {
   static constexpr int HEAD_VERSION = 1;
   static constexpr int COMPAT_VERSION = 1;
 public:
@@ -165,9 +165,9 @@ public:
   ceph::buffer::list& get_lock_data() { return inode_export; }
 
 protected:
-  MMDSSlaveRequest() : SafeMessage{MSG_MDS_SLAVE_REQUEST, HEAD_VERSION, COMPAT_VERSION} { }
+  MMDSSlaveRequest() : MMDSOp{MSG_MDS_SLAVE_REQUEST, HEAD_VERSION, COMPAT_VERSION} { }
   MMDSSlaveRequest(metareqid_t ri, __u32 att, int o) : 
-    SafeMessage{MSG_MDS_SLAVE_REQUEST, HEAD_VERSION, COMPAT_VERSION},
+    MMDSOp{MSG_MDS_SLAVE_REQUEST, HEAD_VERSION, COMPAT_VERSION},
     reqid(ri), attempt(att), op(o), flags(0), lock_type(0),
     inode_export_v(0), srcdn_auth(MDS_RANK_NONE) { }
   ~MMDSSlaveRequest() override {}

diff --git a/src/messages/MMDSSnapUpdate.h b/src/messages/MMDSSnapUpdate.h
index 2fed73a34af6d9c9aacc5235204b49ce88ca8458..45349b42c19428fbc41ba88ea1f8462ce924cc05 100644 (file)
--- a/src/messages/MMDSSnapUpdate.h
+++ b/src/messages/MMDSSnapUpdate.h
@@ -15,9 +15,9 @@
 #ifndef CEPH_MMDSSNAPUPDATE_H
 #define CEPH_MMDSSNAPUPDATE_H
 
-#include "msg/Message.h"
+#include "messages/MMDSOp.h"
 
-class MMDSSnapUpdate : public SafeMessage {
+class MMDSSnapUpdate : public MMDSOp {
 private:
   inodeno_t ino;
   __s16 snap_op;
@@ -29,9 +29,9 @@ public:
   ceph::buffer::list snap_blob;
 
 protected:
-  MMDSSnapUpdate() : SafeMessage{MSG_MDS_SNAPUPDATE} {}
+  MMDSSnapUpdate() : MMDSOp{MSG_MDS_SNAPUPDATE} {}
   MMDSSnapUpdate(inodeno_t i, version_t tid, int op) :
-    SafeMessage{MSG_MDS_SNAPUPDATE}, ino(i), snap_op(op) {
+    MMDSOp{MSG_MDS_SNAPUPDATE}, ino(i), snap_op(op) {
       set_tid(tid);
     }
   ~MMDSSnapUpdate() override {}

diff --git a/src/messages/MMDSTableRequest.h b/src/messages/MMDSTableRequest.h
index 8c1689509612174b27d57f983403ec908d63dee0..5bef687b9a15cdcc956a0e2c5dab0a19c459ba9f 100644 (file)
--- a/src/messages/MMDSTableRequest.h
+++ b/src/messages/MMDSTableRequest.h
@@ -16,10 +16,10 @@
 #ifndef CEPH_MMDSTABLEREQUEST_H
 #define CEPH_MMDSTABLEREQUEST_H
 
-#include "msg/Message.h"
 #include "mds/mds_table_types.h"
+#include "messages/MMDSOp.h"
 
-class MMDSTableRequest : public SafeMessage {
+class MMDSTableRequest : public MMDSOp {
 public:
   __u16 table = 0;
   __s16 op = 0;
@@ -27,9 +27,9 @@ public:
   ceph::buffer::list bl;
 
 protected:
-  MMDSTableRequest() : SafeMessage{MSG_MDS_TABLE_REQUEST} {}
+  MMDSTableRequest() : MMDSOp{MSG_MDS_TABLE_REQUEST} {}
   MMDSTableRequest(int tab, int o, uint64_t r, version_t v=0) : 
-    SafeMessage{MSG_MDS_TABLE_REQUEST},
+    MMDSOp{MSG_MDS_TABLE_REQUEST},
     table(tab), op(o), reqid(r) {
     set_tid(v);
   }