crimson/osd: drop unneccessary variant of PGBackend::getxattr()

Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>

diff --git a/src/crimson/osd/ops_executer.cc b/src/crimson/osd/ops_executer.cc
index 77206b6b061de832d6015c10f713e480ff6d7c51..3b6819278aff3229eedb3673e382e981b0a1efa3 100644 (file)
--- a/src/crimson/osd/ops_executer.cc
+++ b/src/crimson/osd/ops_executer.cc
@@ -1192,7 +1192,7 @@ static PG::interruptible_future<hobject_t> pgls_filter(
   const PGBackend& backend,
   const hobject_t& sobj)
 {
-  if (const auto xattr = filter.get_xattr(); !xattr.empty()) {
+  if (std::string xattr = filter.get_xattr(); !xattr.empty()) {
     logger().debug("pgls_filter: filter is interested in xattr={} for obj={}",
                    xattr, sobj);
     return backend.getxattr(sobj, std::move(xattr)).safe_then_interruptible(

diff --git a/src/crimson/osd/pg_backend.cc b/src/crimson/osd/pg_backend.cc
index 260d11b7d20fa9fb631c51f7d9eca3b4e34ac40a..11367c7b2025bad02f4c1cbdc2716ba698aca98c 100644 (file)
--- a/src/crimson/osd/pg_backend.cc
+++ b/src/crimson/osd/pg_backend.cc
@@ -1166,15 +1166,6 @@ PGBackend::get_attr_ierrorator::future<> PGBackend::getxattr(
   });
 }
 
-PGBackend::get_attr_ierrorator::future<ceph::bufferlist>
-PGBackend::getxattr(
-  const hobject_t& soid,
-  std::string_view key) const
-{
-  return crimson::os::with_store<&crimson::os::FuturizedStore::Shard::get_attr>(
-    store, coll, ghobject_t{soid}, key, 0);
-}
-
 PGBackend::get_attr_ierrorator::future<ceph::bufferlist>
 PGBackend::getxattr(
   const hobject_t& soid,

diff --git a/src/crimson/osd/pg_backend.h b/src/crimson/osd/pg_backend.h
index 54fbb0f770ba5feefab375466d911e6c99ed9523..3f4f7c9de854492a497d6e0c2ed526819631547f 100644 (file)
--- a/src/crimson/osd/pg_backend.h
+++ b/src/crimson/osd/pg_backend.h
@@ -282,9 +282,6 @@ public:
     const ObjectState& os,
     OSDOp& osd_op,
     object_stat_sum_t& delta_stats) const;
-  get_attr_ierrorator::future<ceph::bufferlist> getxattr(
-    const hobject_t& soid,
-    std::string_view key) const;
   get_attr_ierrorator::future<ceph::bufferlist> getxattr(
     const hobject_t& soid,
     std::string&& key) const;