monitoring: rename NVMeoFSingleGatewayGroup alert

Rename the alert to NVMeoFSingleGateway.

The original name was confusing because it
accidently might convey that alert would be
triggered if there is a single gateway group.
Though 'NVMeoFSingleGatewayGroup' alert means that
there is single gateway in a group.

Signed-off-by: Vallari Agrawal <vallari.agrawal@ibm.com>

diff --git a/monitoring/ceph-mixin/prometheus_alerts.libsonnet b/monitoring/ceph-mixin/prometheus_alerts.libsonnet
index f3e06a76f1f7fd1eed671d0bbb9f9670a24d08ac..8fef15e6a16e27b011a330bc2dc8f2501a387ee3 100644 (file)
--- a/monitoring/ceph-mixin/prometheus_alerts.libsonnet
+++ b/monitoring/ceph-mixin/prometheus_alerts.libsonnet
@@ -896,7 +896,7 @@
           },
         },
         {
-          alert: 'NVMeoFSingleGatewayGroup',
+          alert: 'NVMeoFSingleGateway',
           'for': '5m',
           expr: 'count(ceph_nvmeof_gateway_info) by(cluster,group) == 1',
           labels: { severity: 'warning', type: 'ceph_default' },

diff --git a/monitoring/ceph-mixin/prometheus_alerts.yml b/monitoring/ceph-mixin/prometheus_alerts.yml
index f8bcd4ca0e12eaeb829cd8a2d3955a92556a8826..599f819f5446da23d82c5ea385f89124557c5924 100644 (file)
--- a/monitoring/ceph-mixin/prometheus_alerts.yml
+++ b/monitoring/ceph-mixin/prometheus_alerts.yml
@@ -801,7 +801,7 @@ groups:
         labels:
           severity: "warning"
           type: "ceph_default"
-      - alert: "NVMeoFSingleGatewayGroup"
+      - alert: "NVMeoFSingleGateway"
         annotations:
           description: "Although a single member gateway group is valid, it should only be used for test purposes"
           summary: "The gateway group {{ $labels.group }} consists of a single gateway - HA is not possible on cluster {{ $labels.cluster }}"

diff --git a/monitoring/ceph-mixin/tests_alerts/test_alerts.yml b/monitoring/ceph-mixin/tests_alerts/test_alerts.yml
index 7c15798c47d2ebdf4a233cc9a0a740f12bfdc98b..69e7b3a4b9cbc1aaf1376132e0a943609044c88c 100644 (file)
--- a/monitoring/ceph-mixin/tests_alerts/test_alerts.yml
+++ b/monitoring/ceph-mixin/tests_alerts/test_alerts.yml
@@ -2482,7 +2482,7 @@ tests:
           summary: "Max gateway groups exceeded on cluster mycluster"
           description: "You may create many gateway groups, but 4 is the tested limit"
 
- # NVMeoFSingleGatewayGroup
+ # NVMeoFSingleGateway
  - interval: 1m
    input_series:
     - series: 'ceph_nvmeof_gateway_info{group="group-1",addr="1.1.1.2",cluster="mycluster"}'
@@ -2499,7 +2499,7 @@ tests:
            value: 1
    alert_rule_test:
     - eval_time: 5m
-      alertname: NVMeoFSingleGatewayGroup
+      alertname: NVMeoFSingleGateway
       exp_alerts:
       - exp_labels:
           group: group-1