common/async:: Update delete operator in CompletionImpl for improved memory management

Fix UB in CompletionImpl 'operator delete' to eliminate uninitialized memory access

Fixes: https://tracker.ceph.com/issues/72478
Signed-off-by: Edwin Rodriguez <edwin.rodriguez1@ibm.com>

diff --git a/src/common/async/completion.h b/src/common/async/completion.h
index 6cdfaaa63b730a7de32da4228037cfb7233e5d85..a8d0aa847ba6285078c78689bd736580d3b7071f 100644 (file)
--- a/src/common/async/completion.h
+++ b/src/common/async/completion.h
@@ -246,8 +246,17 @@ class CompletionImpl final : public Completion<void(Args...), T> {
                                            std::forward<TArgs>(args)...)};
   }
 
-  static void operator delete(void *p) {
-    static_cast<CompletionImpl*>(p)->destroy();
+  // C++20 destroying delete.
+  // When this overload is selected by `delete ptr`, the compiler does NOT call
+  // ~CompletionImpl(). We must do the full teardown here. We route through
+  // destroy() so that:
+  //  - the completion’s custom lifecycle (defer/dispatch/post) is honored,
+  //  - the object’s destructor is invoked, and
+  //  - deallocation is performed using the matching allocator (RebindAlloc2).
+  // Keep this function noexcept; destroy() is responsible for both destruction
+  // and allocator-aware deallocation.
+  static void operator delete(CompletionImpl* ptr, std::destroying_delete_t) noexcept {
+    ptr->destroy();
   }
 };