rbd: fix leak of fd on error when reading an entire file

CID 717100: Resource leak (RESOURCE_LEAK)
At (6): Handle variable "fd" going out of scope leaks the handle.

Signed-off-by: Josh Durgin <josh.durgin@inktank.com>

diff --git a/src/rbd.cc b/src/rbd.cc
index 5f4d85755f6de117bb1eec766533642ec4dca9bb..f4fade81cc153142e67bcc8010ed5b880a6e7a3b 100644 (file)
--- a/src/rbd.cc
+++ b/src/rbd.cc
@@ -869,6 +869,7 @@ static int read_file(const char *filename, char *buf, size_t bufsize)
     int r = safe_read(fd, buf, bufsize);
     if (r < 0) {
       cerr << "Warning: could not read " << filename << ": " << cpp_strerror(-r) << std::endl;
+      close(fd);
       return r;
     }