]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
SubmittingPatches: clarify how Reviewed-by lines are added 4882/head
authorNathan Cutler <ncutler@suse.com>
Sat, 6 Jun 2015 13:16:16 +0000 (15:16 +0200)
committerNathan Cutler <ncutler@suse.com>
Sat, 6 Jun 2015 13:16:16 +0000 (15:16 +0200)
Signed-off-by: Nathan Cutler <ncutler@suse.com>
SubmittingPatches

index 6b2ff980fe2c685ad28d1a7731cd4d8f981b0437..4831215a875884ee583c857cfdcdf42e5cf711e0 100644 (file)
@@ -273,6 +273,15 @@ A: The target branch depends on the nature of your change:
    you are fixing a bug that exists on the "firefly" branch and that you
    desire that your change be cherry-picked to that branch.
 
+Q: How to include Reviewed-by: tag(s) in my pull request?
+
+   You don't. If someone reviews your pull request, they should indicate they
+   have done so by commenting on it with "+1", "looks good to me", "LGTM",
+   and/or the entire "Reviewed-by: ..." line with their name and email address.
+
+   The developer merging the pull request should note positive reviews and
+   include the appropriate Reviewed-by: lines in the merge commit.
+
 2) Patch submission via ceph-devel@vger.kernel.org
 
 The best way to generate a patch for manual submission is to work from