rgw: do not leak handler in get_handler() error path

If we fail to initialize, delete the handler.

Fixes (part of): #5949
Signed-off-by: Sage Weil <sage@inktank.com>
Reviewed-by: Yehuda Sadeh <yehuda@inktank.com>
(cherry picked from commit 810c52de36719c3ee6cf2bdf59d5cde8840bbe55)

diff --git a/src/rgw/rgw_rest.cc b/src/rgw/rgw_rest.cc
index ee73bb94fa5ec872dced1ff02ba9c280fb69721b..571e486964227554ae20bb194cac5c9128424dd9 100644 (file)
--- a/src/rgw/rgw_rest.cc
+++ b/src/rgw/rgw_rest.cc
@@ -1233,8 +1233,10 @@ RGWHandler *RGWREST::get_handler(RGWRados *store, struct req_state *s, RGWClient
     return NULL;
   }
   *init_error = handler->init(store, s, cio);
-  if (*init_error < 0)
+  if (*init_error < 0) {
+    m->put_handler(handler);
     return NULL;
+  }
 
   return handler;
 }