]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mds: add a HEALTH_WARN message when inline_data is enabled
authorJeff Layton <jlayton@redhat.com>
Thu, 29 Aug 2019 17:05:06 +0000 (13:05 -0400)
committerJeff Layton <jlayton@redhat.com>
Thu, 19 Sep 2019 13:15:29 +0000 (09:15 -0400)
Alert admins when they have filesystems that have the inline_data
feature enabled, as it is being deprecated.

Signed-off-by: Jeff Layton <jlayton@redhat.com>
src/mds/MDSMap.cc

index fb695d0f4d90794b74cbef585e504e2e0dce406c..4ff6c8e500dd1db81458b0d80622ae257fb454d8 100644 (file)
@@ -505,6 +505,15 @@ void MDSMap::get_health_checks(health_check_map_t *checks) const
     ss << "multi-active mds while there are snapshots possibly created by pre-mimic MDS";
     check.detail.push_back(ss.str());
   }
+
+  if (get_inline_data_enabled()) {
+    health_check_t &check = checks->add(
+      "FS_INLINE_DATA_DEPRECATED", HEALTH_WARN,
+      "%num% filesystem%plurals% with deprecated feature inline_data", 1);
+    stringstream ss;
+    ss << "fs " << fs_name << " has deprecated feature inline_data enabled.";
+    check.detail.push_back(ss.str());
+  }
 }
 
 void MDSMap::mds_info_t::encode_versioned(bufferlist& bl, uint64_t features) const