pybind/mgr: check for empty metadata mgr_module:get_metadata()

... rather than just None - looks like we could get back an
empty dictionary when the metadata isn't populated (which is
asynchronous).

Fixes: http://tracker.ceph.com/issues/57072
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 42ee5145a2ad9eec0822e1341cc3c5bd9ca2aae8)

diff --git a/src/pybind/mgr/mgr_module.py b/src/pybind/mgr/mgr_module.py
index d1b6e7dc96e77a255a9bdad55aaf40ed88d9eeef..c827c4feeb68c59cdafd48847cb8cbaeb2bff15b 100644 (file)
--- a/src/pybind/mgr/mgr_module.py
+++ b/src/pybind/mgr/mgr_module.py
@@ -1303,7 +1303,7 @@ class MgrModule(ceph_module.BaseMgrModule, MgrModuleLoggingMixin):
         :rtype: dict, or None if no metadata found
         """
         metadata = self._ceph_get_metadata(svc_type, svc_id)
-        if metadata is None:
+        if not metadata:
             return default
         return metadata