]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
run-standalone.sh: Need double-quotes to handle | in core_pattern 26811/head
authorDavid Zafman <dzafman@redhat.com>
Fri, 15 Feb 2019 00:47:29 +0000 (16:47 -0800)
committerAshish Singh <assingh@redhat.com>
Thu, 7 Mar 2019 07:22:51 +0000 (12:52 +0530)
on all distributions

OpenSUSE does not automatically add the | back when setting
the corepattern.  I tested this on openSUSE Leap 15.0.

Fixes: http://tracker.ceph.com/issues/38325
Signed-off-by: David Zafman <dzafman@redhat.com>
(cherry picked from commit bc2df8c49b17248cc832deae75149d8e26d3f1e7)

qa/run-standalone.sh

index 788a866aa691c02a24cc66e626313f3a52764bf1..b7eb16afb8ddc449fd168c1078bb896176107603 100755 (executable)
@@ -46,7 +46,7 @@ fi
 
 function cleanup() {
     if [ -n "$precore" ]; then
-        sudo sysctl -w ${KERNCORE}=${precore}
+        sudo sysctl -w "${KERNCORE}=${precore}"
     fi
 }
 
@@ -87,7 +87,7 @@ precore="$(sysctl -n $KERNCORE)"
 if [ "$precore" = "$COREPATTERN" ]; then
     precore=""
 else
-    sudo sysctl -w ${KERNCORE}=${COREPATTERN}
+    sudo sysctl -w "${KERNCORE}=${COREPATTERN}"
 fi
 # Clean out any cores in core target directory (currently .)
 if ls $(dirname $(sysctl -n $KERNCORE)) | grep -q '^core\|core$' ; then