]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
ceph-volume: add is_ceph_device unit tests 33608/head
authorJan Fajerski <jfajerski@suse.com>
Wed, 12 Feb 2020 15:49:30 +0000 (16:49 +0100)
committerJan Fajerski <jfajerski@suse.com>
Fri, 28 Feb 2020 12:54:53 +0000 (13:54 +0100)
Signed-off-by: Jan Fajerski <jfajerski@suse.com>
(cherry picked from commit 60d80636e4708761287197c534347f82e307c603)

src/ceph-volume/ceph_volume/tests/api/test_lvm.py

index 43125471bac893e1c665aafa924cd907e91f2764..c0f8e3f53917da03bed85dbd248c16e5848369a7 100644 (file)
@@ -213,6 +213,24 @@ class TestGetVG(object):
         assert api.get_vg(vg_name='foo') == FooVG
 
 
+class TestVolume(object):
+
+    def test_is_ceph_device(self):
+        lv_tags = "ceph.type=data,ceph.osd_id=0"
+        osd = api.Volume(lv_name='osd/volume', lv_tags=lv_tags)
+        assert api.is_ceph_device(osd)
+
+    @pytest.mark.parametrize('dev',[
+        '/dev/sdb',
+        api.VolumeGroup(vg_name='foo'),
+        api.Volume(lv_name='vg/no_osd', lv_tags=''),
+        api.Volume(lv_name='vg/no_osd', lv_tags='ceph.osd_id=null'),
+        None,
+    ])
+    def test_is_not_ceph_device(self, dev):
+        assert not api.is_ceph_device(dev)
+
+
 class TestVolumes(object):
 
     def test_volume_get_has_no_volumes(self, volumes):