]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
lvm/activate.py: clarify error message: fsid refers to osd_fsid 32865/head
authorYaniv Kaul <ykaul@redhat.com>
Thu, 19 Dec 2019 14:54:58 +0000 (16:54 +0200)
committerShyukri Shyukriev <shshyukriev@suse.com>
Sat, 25 Jan 2020 20:44:26 +0000 (22:44 +0200)
Users complained[1] the error message isn't clear, and they thought
it referred to the cluster fsid instead of the osd_fsid.
Made it clearer.

[1] rook/rook#4547

Fixes: https://tracker.ceph.com/issues/43442
Signed-off-by: Yaniv Kaul <ykaul@redhat.com>
(cherry picked from commit ff3ba9200a6b5856fbdf4372fe292a7b94dd2539)

src/ceph-volume/ceph_volume/devices/lvm/activate.py

index d46db9edfa5866aa4632134940cdbde02267ca0e..ebdb2062461667b3561f50f78c740da27a2fdcc6 100644 (file)
@@ -248,7 +248,7 @@ class Activate(object):
         elif osd_fsid and not osd_id:
             lvs.filter(lv_tags={'ceph.osd_fsid': osd_fsid})
         if not lvs:
-            raise RuntimeError('could not find osd.%s with fsid %s' % (osd_id, osd_fsid))
+            raise RuntimeError('could not find osd.%s with osd_fsid %s' % (osd_id, osd_fsid))
         # This argument is only available when passed in directly or via
         # systemd, not when ``create`` is being used
         if getattr(args, 'auto_detect_objectstore', False):