]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
qa: deep merge top level overrides for fuse/kclient
authorPatrick Donnelly <pdonnell@redhat.com>
Wed, 17 Feb 2021 02:37:35 +0000 (18:37 -0800)
committerPatrick Donnelly <pdonnell@redhat.com>
Sat, 5 Jun 2021 02:15:12 +0000 (19:15 -0700)
This allows for array/dict configs like mntopts to accumulate changes
from multiple yaml fragments.

Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
qa/tasks/ceph_fuse.py
qa/tasks/kclient.py

index d01c313110b3e3c9583807615401b1ca6499fe21..2712229f97231cf5ef469b2b2757a8758ad75ae6 100644 (file)
@@ -108,9 +108,7 @@ def task(ctx, config):
         if client_config is None:
             client_config = {}
         # top level overrides
-        for k, v in top_overrides.items():
-            if v is not None:
-                client_config[k] = v
+        misc.deep_merge(client_config, top_overrides)
         # mount specific overrides
         client_config_overrides = overrides.get(entity)
         misc.deep_merge(client_config, client_config_overrides)
index be75286bd0dc81be6181eb15cd8a64e0af0b7bce..d7bc9fa835b55ea8817f7ac2b1c26aa164873f7e 100644 (file)
@@ -84,9 +84,7 @@ def task(ctx, config):
         if client_config is None:
             client_config = {}
         # top level overrides
-        for k, v in top_overrides.items():
-            if v is not None:
-                client_config[k] = v
+        deep_merge(client_config, top_overrides)
         # mount specific overrides
         client_config_overrides = overrides.get(entity)
         deep_merge(client_config, client_config_overrides)