mgr/balancer: changed logs to debug level

In order to reduce the overall log load at info level, logs that
were deemed unnecessary for users was moved to debug
level. This includes logs that repeat information and logs
that track no actual balancing changes.

Signed-off-by: Timothy Q Nguyen <timqn22@gmail.com>

diff --git a/src/pybind/mgr/balancer/module.py b/src/pybind/mgr/balancer/module.py
index 476304275c1cf46a39e117bdfa6cba589c59f682..ee18869cc531d8ed8c174dd19424fcb60fa4f5d1 100644 (file)
--- a/src/pybind/mgr/balancer/module.py
+++ b/src/pybind/mgr/balancer/module.py
@@ -1020,7 +1020,7 @@ class Module(MgrModule):
         return pe.show(verbose=verbose)
 
     def optimize(self, plan: Plan) -> Tuple[int, str]:
-        self.log.info('Optimize plan %s' % plan.name)
+        self.log.debug('Optimize plan %s' % plan.name)
         max_misplaced = cast(float, self.get_ceph_option('target_max_misplaced_ratio'))
         self.log.info('Mode %s, max misplaced %f' %
                       (plan.mode, max_misplaced))
@@ -1073,7 +1073,7 @@ class Module(MgrModule):
                 return -errno.EINVAL, detail
 
     def do_read_balancing(self, plan: Plan) -> Tuple[int, str]:
-        self.log.info('do_read_balancing')
+        self.log.debug('do_read_balancing')
         osdmap_dump = plan.osdmap_dump
         msg = 'Unable to find further optimization, ' \
               'or distribution is already perfect'
@@ -1086,7 +1086,7 @@ class Module(MgrModule):
             detail = 'No pools available'
             self.log.info(detail)
             return -errno.ENOENT, detail
-        self.log.info('pools %s' % pools)
+        self.log.debug('pools %s' % pools)
 
         adjusted_pools = []
         inc = plan.inc
@@ -1144,14 +1144,16 @@ class Module(MgrModule):
             self.no_optimization_needed = True
             self.log.debug('unable to balance reads.')
             return -errno.EALREADY, msg
-        self.log.info('prepared {} read changes'.format(total_num_changes))
+        if total_num_changes != 0:
+            self.log.info('prepared {} read changes'.format(total_num_changes))
         if total_num_changes == 0:
+            self.log.debug('prepared {} read changes'.format(total_num_changes))
             self.no_optimization_needed = True
             return -errno.EALREADY, msg
         return 0, ''
 
     def do_upmap(self, plan: Plan) -> Tuple[int, str]:
-        self.log.info('do_upmap')
+        self.log.debug('do_upmap')
         max_optimizations = cast(float, self.get_module_option('upmap_max_optimizations'))
         max_deviation = cast(int, self.get_module_option('upmap_max_deviation'))
         osdmap_dump = plan.osdmap_dump
@@ -1166,7 +1168,7 @@ class Module(MgrModule):
             return -errno.ENOENT, detail
         # shuffle pool list so they all get equal (in)attention
         random.shuffle(pools)
-        self.log.info('pools %s' % pools)
+        self.log.debug('pools %s' % pools)
 
         adjusted_pools = []
         inc = plan.inc
@@ -1210,8 +1212,10 @@ class Module(MgrModule):
             left -= did
             if left <= 0:
                 break
-        self.log.info('prepared %d/%d upmap changes' % (total_did, max_optimizations))
+        if total_did != 0:
+            self.log.info('prepared %d/%d upmap changes' % (total_did, max_optimizations))
         if total_did == 0:
+            self.log.debug('prepared %d/%d upmap changes' % (total_did, max_optimizations))
             self.no_optimization_needed = True
             return -errno.EALREADY, 'Unable to find further optimization, ' \
                                     'or pool(s) pg_num is decreasing, ' \
@@ -1219,7 +1223,7 @@ class Module(MgrModule):
         return 0, ''
 
     def do_crush_compat(self, plan: MsPlan) -> Tuple[int, str]:
-        self.log.info('do_crush_compat')
+        self.log.debug('do_crush_compat')
         max_iterations = cast(int, self.get_module_option('crush_compat_max_iterations'))
         if max_iterations < 1:
             return -errno.EINVAL, '"crush_compat_max_iterations" must be >= 1'
@@ -1296,7 +1300,7 @@ class Module(MgrModule):
                 osds = len(best_pe.target_by_root[root])
                 min_pgs = osds * min_pg_per_osd
                 if best_pe.total_by_root[root][key] < min_pgs:
-                    self.log.info('Skipping root %s (pools %s), total pgs %d '
+                    self.log.debug('Skipping root %s (pools %s), total pgs %d '
                                   '< minimum %d (%d per osd)',
                                   root, pools,
                                   best_pe.total_by_root[root][key],