]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mon/PGMap: 'unclean' does not imply damaged 18493/head
authorSage Weil <sage@redhat.com>
Mon, 23 Oct 2017 21:07:48 +0000 (16:07 -0500)
committerSage Weil <sage@redhat.com>
Mon, 23 Oct 2017 21:27:07 +0000 (16:27 -0500)
Everything (that I can think of) that would lead to a PG being unclean is
already reported via another health message.  And there are cases where a
PG is unclean (e.g., because it is backfilling) where we are not degraded.

Fix by ignoring this flag in the health checks.

Signed-off-by: Sage Weil <sage@redhat.com>
src/mon/PGMap.cc

index 7392ebcf1cc9d171c2d0734425b273560840b422..82eb10cbc0e6da64710ddc5bfada5fb8f6c0a607 100644 (file)
@@ -2145,8 +2145,7 @@ void PGMap::get_health_checks(
     { PG_STATE_UNDERSIZED,       {DEGRADED,    [](const pg_stat_t &p){return p.last_fullsized;} } },
     { PG_STATE_STALE,            {UNAVAILABLE, [](const pg_stat_t &p){return p.last_unstale;}   } },
     // Delayed and inverted reports
-    { PG_STATE_ACTIVE,           {UNAVAILABLE, [](const pg_stat_t &p){return p.last_active;}, true} },
-    { PG_STATE_CLEAN,            {DEGRADED,    [](const pg_stat_t &p){return p.last_clean;}, true} }
+    { PG_STATE_ACTIVE,           {UNAVAILABLE, [](const pg_stat_t &p){return p.last_active;}, true} }
   };
 
   // Specialized state printer that takes account of inversion of