]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
osd: fix backwards min/max osd utilization
authorDan van der Ster <daniel.vanderster@cern.ch>
Fri, 22 Apr 2016 09:19:30 +0000 (11:19 +0200)
committerSage Weil <sage@redhat.com>
Fri, 22 Apr 2016 14:31:39 +0000 (10:31 -0400)
Signed-off-by: Dan van der Ster <daniel.vanderster@cern.ch>
(cherry picked from commit 7529851f2a186501664461916f785da8456ad612)

src/osd/OSDMap.cc

index 3d06df65b32a522d939df1c8869a7a5c74fa2fb6..7961d2f96771a74ca01df264e8783cbbec3c839b 100644 (file)
@@ -2953,12 +2953,12 @@ int OSDMap::summarize_mapping_stats(
       base_stddev += base_diff * base_diff;
       float new_diff = (float)new_by_osd[osd] - avg_pg;
       new_stddev += new_diff * new_diff;
-      if (min < 0 || min_base_pg < base_by_osd[osd]) {
+      if (min < 0 || base_by_osd[osd] < min_base_pg) {
        min = osd;
        min_base_pg = base_by_osd[osd];
        min_new_pg = new_by_osd[osd];
       }
-      if (max < 0 || max_base_pg > base_by_osd[osd]) {
+      if (max < 0 || base_by_osd[osd] > max_base_pg) {
        max = osd;
        max_base_pg = base_by_osd[osd];
        max_new_pg = new_by_osd[osd];