mgr/dashboard: fix CephPGImbalance alert

Fixes: https://tracker.ceph.com/issues/55568
Signed-off-by: Aashish Sharma <aasharma@redhat.com>

diff --git a/src/pybind/mgr/dashboard/controllers/prometheus.py b/src/pybind/mgr/dashboard/controllers/prometheus.py
index bed919327b6f4206f3e61beff656948cb9d720f1..d9a360799d9eb9403d2d81da0321b63aabe79239 100644 (file)
--- a/src/pybind/mgr/dashboard/controllers/prometheus.py
+++ b/src/pybind/mgr/dashboard/controllers/prometheus.py
@@ -105,14 +105,15 @@ class PrometheusRESTController(RESTController):
                 component='prometheus')
         balancer_status = self.balancer_status()
         if content['status'] == 'success':  # pylint: disable=R1702
+            alerts_info = []
             if 'data' in content:
                 if balancer_status['active'] and balancer_status['no_optimization_needed'] and path == '/alerts':  # noqa E501  #pylint: disable=line-too-long
                     for alert in content['data']:
                         for k, v in alert.items():
                             if k == 'labels':
-                                for key, value in v.items():
-                                    if key == 'alertname' and value == 'CephPGImbalance':
-                                        content['data'].remove(alert)
+                                alerts_info.append(v)
+                    alerts_info = [i for i in alerts_info if i['alertname'] != 'CephPGImbalance']
+                    return alerts_info
                 return content['data']
             return content
         raise DashboardException(content, http_status_code=400, component='prometheus')