]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
osd: upgrade a bunch of perf counters to PRIO_USEFUL
authorJohn Spray <john.spray@redhat.com>
Wed, 13 Sep 2017 11:07:50 +0000 (07:07 -0400)
committerJohn Spray <john.spray@redhat.com>
Wed, 1 Nov 2017 23:03:25 +0000 (23:03 +0000)
These are broadly the OSD-wide IO stats, which happen
to also be the ones that were named in the
prometheus plugin until I changed it to be
priority-based.

Signed-off-by: John Spray <john.spray@redhat.com>
(cherry picked from commit a1cc4ba2993de62b60fd1e58a9704877a6da5fe4)

src/osd/OSD.cc

index c586afccefda2c06273b1aec224188605d45bdd0..c2f563107a7685d15d795c65f5335e9bdc132d1d 100644 (file)
@@ -2964,6 +2964,9 @@ void OSD::create_logger()
   };
 
 
+  // All the basic OSD operation stats are to be considered useful
+  osd_plb.set_prio_default(PerfCountersBuilder::PRIO_USEFUL);
+
   osd_plb.add_u64(
     l_osd_op_wip, "op_wip",
     "Replication operations currently being processed (primary)");
@@ -3051,6 +3054,10 @@ void OSD::create_logger()
     l_osd_op_rw_prepare_lat, "op_rw_prepare_latency",
     "Latency of read-modify-write operations (excluding queue time and wait for finished)");
 
+  // Now we move on to some more obscure stats, revert to assuming things
+  // are low priority unless otherwise specified.
+  osd_plb.set_prio_default(PerfCountersBuilder::PRIO_DEBUGONLY);
+
   osd_plb.add_time_avg(l_osd_op_before_queue_op_lat, "op_before_queue_op_lat",
     "Latency of IO before calling queue(before really queue into ShardedOpWq)"); // client io before queue op_wq latency
   osd_plb.add_time_avg(l_osd_op_before_dequeue_op_lat, "op_before_dequeue_op_lat",