]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rbd-mirror: tests: ImageSyncThrottler unit tests 9623/head
authorRicardo Dias <rdias@suse.com>
Thu, 9 Jun 2016 09:40:23 +0000 (10:40 +0100)
committerRicardo Dias <rdias@suse.com>
Tue, 28 Jun 2016 12:17:29 +0000 (13:17 +0100)
Signed-off-by: Ricardo Dias <rdias@suse.com>
src/test/Makefile-client.am
src/test/rbd_mirror/CMakeLists.txt
src/test/rbd_mirror/test_mock_ImageSyncThrottler.cc [new file with mode: 0644]

index 983047102a290194f390e4d526e7a303073afab1..e653c918f8f9f2ee08a1abcba7892e3ac52cbed9 100644 (file)
@@ -485,6 +485,7 @@ unittest_rbd_mirror_SOURCES = \
        test/rbd_mirror/test_mock_fixture.cc \
        test/rbd_mirror/test_mock_ImageReplayer.cc \
        test/rbd_mirror/test_mock_ImageSync.cc \
+       test/rbd_mirror/test_mock_ImageSyncThrottler.cc \
        test/rbd_mirror/image_replayer/test_mock_BootstrapRequest.cc \
        test/rbd_mirror/image_replayer/test_mock_CreateImageRequest.cc \
        test/rbd_mirror/image_sync/test_mock_ImageCopyRequest.cc \
index c979b36e579c3206f52cda3b81077585be623b90..70d13408194adf7c41cb78aa7de7613309cec5c5 100644 (file)
@@ -15,6 +15,7 @@ add_executable(unittest_rbd_mirror
   test_mock_fixture.cc
   test_mock_ImageReplayer.cc
   test_mock_ImageSync.cc
+  test_mock_ImageSyncThrottler.cc
   image_replayer/test_mock_BootstrapRequest.cc
   image_replayer/test_mock_CreateImageRequest.cc
   image_sync/test_mock_ImageCopyRequest.cc
diff --git a/src/test/rbd_mirror/test_mock_ImageSyncThrottler.cc b/src/test/rbd_mirror/test_mock_ImageSyncThrottler.cc
new file mode 100644 (file)
index 0000000..31829bd
--- /dev/null
@@ -0,0 +1,398 @@
+// -*- mode:C; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-
+// vim: ts=8 sw=2 smarttab
+/*
+ * Ceph - scalable distributed file system
+ *
+ * Copyright (C) 2016 SUSE LINUX GmbH
+ *
+ * This is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License version 2.1, as published by the Free Software
+ * Foundation.  See file COPYING.
+ *
+ */
+
+#include "test/rbd_mirror/test_mock_fixture.h"
+#include "librbd/journal/TypeTraits.h"
+#include "test/journal/mock/MockJournaler.h"
+#include "test/librbd/mock/MockImageCtx.h"
+#include "librbd/ImageState.h"
+#include "tools/rbd_mirror/Threads.h"
+#include "tools/rbd_mirror/ImageSync.h"
+
+namespace librbd {
+namespace journal {
+
+template <>
+struct TypeTraits<librbd::MockImageCtx> {
+  typedef ::journal::MockJournaler Journaler;
+};
+
+} // namespace journal
+} // namespace librbd
+
+namespace rbd {
+namespace mirror {
+
+using ::testing::Invoke;
+
+typedef ImageSync<librbd::MockImageCtx> MockImageSync;
+
+template<>
+class ImageSync<librbd::MockImageCtx> {
+public:
+  static std::vector<MockImageSync *> instances;
+
+  Context *on_finish;
+  bool syncing = false;
+
+  static ImageSync* create(librbd::MockImageCtx *local_image_ctx,
+                           librbd::MockImageCtx *remote_image_ctx,
+                           SafeTimer *timer, Mutex *timer_lock,
+                           const std::string &mirror_uuid,
+                           journal::MockJournaler *journaler,
+                           librbd::journal::MirrorPeerClientMeta *client_meta,
+                           ContextWQ *work_queue, Context *on_finish,
+                           ProgressContext *progress_ctx = nullptr) {
+    ImageSync *sync = new ImageSync();
+    sync->on_finish = on_finish;
+
+    EXPECT_CALL(*sync, send())
+      .WillRepeatedly(Invoke([sync]() {
+            sync->syncing = true;
+          }));
+
+    return sync;
+  }
+
+  void finish(int r) {
+    on_finish->complete(r);
+    put();
+  }
+
+  void get() {
+    instances.push_back(this);
+  }
+
+  void put() { delete this; }
+
+  MOCK_METHOD0(cancel, void());
+  MOCK_METHOD0(send, void());
+
+};
+
+
+std::vector<MockImageSync *> MockImageSync::instances;
+
+} // namespace mirror
+} // namespace rbd
+
+
+// template definitions
+#include "tools/rbd_mirror/ImageSyncThrottler.cc"
+template class rbd::mirror::ImageSyncThrottler<librbd::MockImageCtx>;
+
+namespace rbd {
+namespace mirror {
+
+class TestMockImageSyncThrottler : public TestMockFixture {
+public:
+  typedef ImageSyncThrottler<librbd::MockImageCtx> MockImageSyncThrottler;
+
+  virtual void SetUp() {
+    TestMockFixture::SetUp();
+
+    librbd::RBD rbd;
+    ASSERT_EQ(0, create_image(rbd, m_remote_io_ctx, m_image_name, m_image_size));
+    ASSERT_EQ(0, open_image(m_remote_io_ctx, m_image_name, &m_remote_image_ctx));
+
+    ASSERT_EQ(0, create_image(rbd, m_local_io_ctx, m_image_name, m_image_size));
+    ASSERT_EQ(0, open_image(m_local_io_ctx, m_image_name, &m_local_image_ctx));
+
+    mock_sync_throttler = new MockImageSyncThrottler();
+
+    m_mock_local_image_ctx = new librbd::MockImageCtx(*m_local_image_ctx);
+    m_mock_remote_image_ctx = new librbd::MockImageCtx(*m_remote_image_ctx);
+    m_mock_journaler = new journal::MockJournaler();
+  }
+
+  virtual void TearDown() {
+    MockImageSync::instances.clear();
+    delete mock_sync_throttler;
+    delete m_mock_local_image_ctx;
+    delete m_mock_remote_image_ctx;
+    delete m_mock_journaler;
+    TestMockFixture::TearDown();
+  }
+
+  void start_sync(const std::string& image_id, Context *ctx) {
+    m_mock_local_image_ctx->id = image_id;
+    mock_sync_throttler->start_sync(m_mock_local_image_ctx,
+                                    m_mock_remote_image_ctx,
+                                    m_threads->timer,
+                                    &m_threads->timer_lock,
+                                    "mirror_uuid",
+                                    m_mock_journaler,
+                                    &m_client_meta,
+                                    m_threads->work_queue,
+                                    ctx);
+  }
+
+  void cancel(const std::string& mirror_uuid, MockImageSync *sync,
+              bool running=true) {
+    if (running) {
+      EXPECT_CALL(*sync, cancel())
+        .WillOnce(Invoke([sync]() {
+              sync->finish(-ECANCELED);
+            }));
+    } else {
+      EXPECT_CALL(*sync, cancel()).Times(0);
+    }
+    mock_sync_throttler->cancel_sync(mirror_uuid);
+  }
+
+  librbd::ImageCtx *m_remote_image_ctx;
+  librbd::ImageCtx *m_local_image_ctx;
+  librbd::MockImageCtx *m_mock_local_image_ctx;
+  librbd::MockImageCtx *m_mock_remote_image_ctx;
+  journal::MockJournaler *m_mock_journaler;
+  librbd::journal::MirrorPeerClientMeta m_client_meta;
+  MockImageSyncThrottler *mock_sync_throttler;
+};
+
+TEST_F(TestMockImageSyncThrottler, Single_Sync) {
+  C_SaferCond ctx;
+  start_sync("image_id", &ctx);
+
+  ASSERT_EQ(1u, MockImageSync::instances.size());
+  MockImageSync *sync = MockImageSync::instances[0];
+  ASSERT_EQ(true, sync->syncing);
+  sync->finish(0);
+  ASSERT_EQ(0, ctx.wait());
+}
+
+TEST_F(TestMockImageSyncThrottler, Multiple_Syncs) {
+  mock_sync_throttler->set_max_concurrent_syncs(2);
+
+  C_SaferCond ctx1;
+  start_sync("image_id_1", &ctx1);
+  C_SaferCond ctx2;
+  start_sync("image_id_2", &ctx2);
+  C_SaferCond ctx3;
+  start_sync("image_id_3", &ctx3);
+  C_SaferCond ctx4;
+  start_sync("image_id_4", &ctx4);
+
+  ASSERT_EQ(4u, MockImageSync::instances.size());
+
+  MockImageSync *sync1 = MockImageSync::instances[0];
+  ASSERT_TRUE(sync1->syncing);
+
+  MockImageSync *sync2 = MockImageSync::instances[1];
+  ASSERT_TRUE(sync2->syncing);
+
+  MockImageSync *sync3 = MockImageSync::instances[2];
+  ASSERT_FALSE(sync3->syncing);
+
+  MockImageSync *sync4 = MockImageSync::instances[3];
+  ASSERT_FALSE(sync4->syncing);
+
+  sync1->finish(0);
+  ASSERT_EQ(0, ctx1.wait());
+
+  ASSERT_TRUE(sync3->syncing);
+  sync3->finish(-EINVAL);
+  ASSERT_EQ(-EINVAL, ctx3.wait());
+
+  ASSERT_TRUE(sync4->syncing);
+
+  sync2->finish(0);
+  ASSERT_EQ(0, ctx2.wait());
+
+  sync4->finish(0);
+  ASSERT_EQ(0, ctx4.wait());
+}
+
+TEST_F(TestMockImageSyncThrottler, Cancel_Running_Sync) {
+  C_SaferCond ctx1;
+  start_sync("image_id_1", &ctx1);
+  C_SaferCond ctx2;
+  start_sync("image_id_2", &ctx2);
+
+  ASSERT_EQ(2u, MockImageSync::instances.size());
+
+  MockImageSync *sync1 = MockImageSync::instances[0];
+  ASSERT_TRUE(sync1->syncing);
+
+  MockImageSync *sync2 = MockImageSync::instances[1];
+  ASSERT_TRUE(sync2->syncing);
+
+  cancel("image_id_2", sync2);
+  ASSERT_EQ(-ECANCELED, ctx2.wait());
+
+  sync1->finish(0);
+  ASSERT_EQ(0, ctx1.wait());
+}
+
+TEST_F(TestMockImageSyncThrottler, Cancel_Waiting_Sync) {
+  mock_sync_throttler->set_max_concurrent_syncs(1);
+
+  C_SaferCond ctx1;
+  start_sync("image_id_1", &ctx1);
+  C_SaferCond ctx2;
+  start_sync("image_id_2", &ctx2);
+
+  ASSERT_EQ(2u, MockImageSync::instances.size());
+
+  MockImageSync *sync1 = MockImageSync::instances[0];
+  ASSERT_TRUE(sync1->syncing);
+
+  MockImageSync *sync2 = MockImageSync::instances[1];
+  ASSERT_FALSE(sync2->syncing);
+
+  cancel("image_id_2", sync2, false);
+  ASSERT_EQ(-ECANCELED, ctx2.wait());
+
+  sync1->finish(0);
+  ASSERT_EQ(0, ctx1.wait());
+}
+
+TEST_F(TestMockImageSyncThrottler, Cancel_Running_Sync_Start_Waiting) {
+  mock_sync_throttler->set_max_concurrent_syncs(1);
+
+  C_SaferCond ctx1;
+  start_sync("image_id_1", &ctx1);
+  C_SaferCond ctx2;
+  start_sync("image_id_2", &ctx2);
+
+  ASSERT_EQ(2u, MockImageSync::instances.size());
+
+  MockImageSync *sync1 = MockImageSync::instances[0];
+  ASSERT_TRUE(sync1->syncing);
+
+  MockImageSync *sync2 = MockImageSync::instances[1];
+  ASSERT_FALSE(sync2->syncing);
+
+  cancel("image_id_1", sync1);
+  ASSERT_EQ(-ECANCELED, ctx1.wait());
+
+  ASSERT_TRUE(sync2->syncing);
+  sync2->finish(0);
+  ASSERT_EQ(0, ctx2.wait());
+}
+
+TEST_F(TestMockImageSyncThrottler, Increase_Max_Concurrent_Syncs) {
+  mock_sync_throttler->set_max_concurrent_syncs(2);
+
+  C_SaferCond ctx1;
+  start_sync("image_id_1", &ctx1);
+  C_SaferCond ctx2;
+  start_sync("image_id_2", &ctx2);
+  C_SaferCond ctx3;
+  start_sync("image_id_3", &ctx3);
+  C_SaferCond ctx4;
+  start_sync("image_id_4", &ctx4);
+  C_SaferCond ctx5;
+  start_sync("image_id_5", &ctx5);
+
+  ASSERT_EQ(5u, MockImageSync::instances.size());
+
+  MockImageSync *sync1 = MockImageSync::instances[0];
+  ASSERT_TRUE(sync1->syncing);
+
+  MockImageSync *sync2 = MockImageSync::instances[1];
+  ASSERT_TRUE(sync2->syncing);
+
+  MockImageSync *sync3 = MockImageSync::instances[2];
+  ASSERT_FALSE(sync3->syncing);
+
+  MockImageSync *sync4 = MockImageSync::instances[3];
+  ASSERT_FALSE(sync4->syncing);
+
+  MockImageSync *sync5 = MockImageSync::instances[4];
+  ASSERT_FALSE(sync5->syncing);
+
+  mock_sync_throttler->set_max_concurrent_syncs(4);
+
+  ASSERT_TRUE(sync3->syncing);
+  ASSERT_TRUE(sync4->syncing);
+  ASSERT_FALSE(sync5->syncing);
+
+  sync1->finish(0);
+  ASSERT_EQ(0, ctx1.wait());
+
+  ASSERT_TRUE(sync5->syncing);
+  sync5->finish(-EINVAL);
+  ASSERT_EQ(-EINVAL, ctx5.wait());
+
+  sync2->finish(0);
+  ASSERT_EQ(0, ctx2.wait());
+
+  sync3->finish(0);
+  ASSERT_EQ(0, ctx3.wait());
+
+  sync4->finish(0);
+  ASSERT_EQ(0, ctx4.wait());
+}
+
+TEST_F(TestMockImageSyncThrottler, Decrease_Max_Concurrent_Syncs) {
+  mock_sync_throttler->set_max_concurrent_syncs(4);
+
+  C_SaferCond ctx1;
+  start_sync("image_id_1", &ctx1);
+  C_SaferCond ctx2;
+  start_sync("image_id_2", &ctx2);
+  C_SaferCond ctx3;
+  start_sync("image_id_3", &ctx3);
+  C_SaferCond ctx4;
+  start_sync("image_id_4", &ctx4);
+  C_SaferCond ctx5;
+  start_sync("image_id_5", &ctx5);
+
+  ASSERT_EQ(5u, MockImageSync::instances.size());
+
+  MockImageSync *sync1 = MockImageSync::instances[0];
+  ASSERT_TRUE(sync1->syncing);
+
+  MockImageSync *sync2 = MockImageSync::instances[1];
+  ASSERT_TRUE(sync2->syncing);
+
+  MockImageSync *sync3 = MockImageSync::instances[2];
+  ASSERT_TRUE(sync3->syncing);
+
+  MockImageSync *sync4 = MockImageSync::instances[3];
+  ASSERT_TRUE(sync4->syncing);
+
+  MockImageSync *sync5 = MockImageSync::instances[4];
+  ASSERT_FALSE(sync5->syncing);
+
+  mock_sync_throttler->set_max_concurrent_syncs(2);
+
+  ASSERT_FALSE(sync5->syncing);
+
+  sync1->finish(0);
+  ASSERT_EQ(0, ctx1.wait());
+
+  ASSERT_FALSE(sync5->syncing);
+
+  sync2->finish(0);
+  ASSERT_EQ(0, ctx2.wait());
+
+  ASSERT_FALSE(sync5->syncing);
+
+  sync3->finish(0);
+  ASSERT_EQ(0, ctx3.wait());
+
+  ASSERT_TRUE(sync5->syncing);
+
+  sync4->finish(0);
+  ASSERT_EQ(0, ctx4.wait());
+
+  sync5->finish(0);
+  ASSERT_EQ(0, ctx5.wait());
+}
+
+
+} // namespace mirror
+} // namespace rbd
+