]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
mds: Remove unnecessary std::move on const expression in MetricsHandler::handle_payload 65884/head
authorEdwin Rodriguez <edwin.rodriguez1@ibm.com>
Wed, 8 Oct 2025 16:20:36 +0000 (12:20 -0400)
committerEdwin Rodriguez <edwin.rodriguez1@ibm.com>
Mon, 13 Oct 2025 12:39:45 +0000 (08:39 -0400)
Fixes: https://tracker.ceph.com/issues/73430
Signed-off-by: Edwin Rodriguez <edwin.rodriguez1@ibm.com>
src/mds/MetricsHandler.cc

index a67e90134a93f04de6981b1ea8c76f4d9fd33180..23811a42a75da4d9359487b17675fb1a22a70b5b 100644 (file)
@@ -368,7 +368,9 @@ std::chrono::steady_clock::now().time_since_epoch()).count());
     auto& vec = subvolume_metrics_map[path];
 
     dout(20) << " accumulating subv_metric " << payload.subvolume_metrics[i] << dendl;
-    vec.emplace_back(std::move(payload.subvolume_metrics[i]));
+    // std::move of the const expression of the trivially-copyable type 'const value_type'
+    // (aka 'const AggregatedIOMetrics') has no effect; remove std::move()
+    vec.emplace_back(payload.subvolume_metrics[i]);
     vec.back().time_stamp = now_ms;
   }
 }