]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mon/OSDMonitor: only take in osd into consideration when trimming osdmaps 36981/head
authorKefu Chai <kchai@redhat.com>
Thu, 3 Sep 2020 15:02:58 +0000 (23:02 +0800)
committerNeha Ojha <nojha@redhat.com>
Fri, 4 Sep 2020 00:13:46 +0000 (00:13 +0000)
we should not take down osd into consideration when trimming osdmap. in
e62269c892, we decrease the upper bound of range of osdmaps to be trimmed
if the given osd is out. but we should have to decrease it only if the
osd in question is still *in*.

so, in this change, the min_lec is decreased only if the osd in question
is *in*.

Fixes: https://tracker.ceph.com/issues/47290
Signed-off-by: Kefu Chai <kchai@redhat.com>
(cherry picked from commit 79175740cf2394bba74163ca8a5131419b9641ed)

 Conflicts:
src/mon/OSDMonitor.cc - trivial resolution

src/mon/OSDMonitor.cc

index e62d518b9c1ae9aec4fb1c6e93ed3fc8208e15ad..e256d10aa57af0fbf5655b7bf5eb21c5f1a07fa7 100644 (file)
@@ -2225,7 +2225,7 @@ epoch_t OSDMonitor::get_min_last_epoch_clean() const
   // don't trim past the oldest reported osd epoch
   for (auto& osd_epoch : osd_epochs) {
     if (osd_epoch.second < floor &&
-        osdmap.is_out(osd_epoch.first)) {
+        osdmap.is_in(osd_epoch.first)) {
       floor = osd_epoch.second;
     }
   }