osdmaptool: fix pg_t::parse() return value check

CID 716876: Operands don't affect result (CONSTANT_EXPRESSION_RESULT)
At (1): pgid.parse(test_map_pg.c_str()) < 0 is always false regardless of the values of its operands. This occurs as the logical operand of if.

Signed-off-by: Sage Weil <sage@inktank.com>

diff --git a/src/osdmaptool.cc b/src/osdmaptool.cc
index bb907d7d516130a04e20d3cd2b58c8c66746bdb9..ef8af8f90e015da867e18e058e6e8990bf13fe41 100644 (file)
--- a/src/osdmaptool.cc
+++ b/src/osdmaptool.cc
@@ -257,7 +257,7 @@ int main(int argc, const char **argv)
   }  
   if (!test_map_pg.empty()) {
     pg_t pgid;
-    if (pgid.parse(test_map_pg.c_str()) < 0) {
+    if (!pgid.parse(test_map_pg.c_str())) {
       cerr << me << ": failed to parse pg '" << test_map_pg
           << "', r = " << r << std::endl;
       usage();