Fix memory leak in Backtrace::print()

Free already allocated memory if short of memory

Signed-off-by: Li Wang <liwang@ubuntukylin.com>
Reviewed-by: Sage Weil <sage@inktank.com>

diff --git a/src/common/BackTrace.cc b/src/common/BackTrace.cc
index 6cace65ab6d4339dac7fc16d5b27ad5651f62b83..886ed6a16d4b671513f16039e300bde8905def02 100644 (file)
--- a/src/common/BackTrace.cc
+++ b/src/common/BackTrace.cc
@@ -36,8 +36,10 @@ void BackTrace::print(std::ostream& out)
     if (begin && end) {
       int len = end - begin;
       char *foo = (char *)malloc(len+1);
-      if (!foo)
-        return;
+      if (!foo) {
+       free(function);
+       return;
+      }
       memcpy(foo, begin, len);
       foo[len] = 0;