]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
rc/test/osdc/object_cacher_stress.cc: fix comparison 15353/head
authorWillem Jan Withagen <wjw@digiware.nl>
Mon, 29 May 2017 21:06:46 +0000 (23:06 +0200)
committerWillem Jan Withagen <wjw@digiware.nl>
Fri, 2 Jun 2017 09:50:07 +0000 (11:50 +0200)
Clang complains:
  /home/jenkins/workspace/ceph-freebsd/src/test/osdc/object_cacher_stress.cc:50:26: error: ordered comparison between pointer and zero ('std::atomic<unsigned int> *' and 'int')
      assert(m_outstanding > 0);
               ~~~~~~~~~~~~~ ^ ~
  /home/jenkins/workspace/ceph-freebsd/src/include/assert.h:117:5: note: expanded from macro 'assert'
    ((expr)                                                               \
        ^~~~
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
src/test/osdc/object_cacher_stress.cc

index fc9c56f955548b09cdd33a40331a672fa1ff3f39..103347d3ac8a0359d0a22fc3d044877d3587fd3d 100644 (file)
@@ -47,8 +47,8 @@ public:
     : m_op(op), m_outstanding(outstanding) {}
   void finish(int r) override {
     m_op->done++;
-    assert(m_outstanding > 0);
-    *m_outstanding--;
+    assert(*m_outstanding > 0);
+    (*m_outstanding)--;
   }
 };