]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
seastore: utilize unique_ptr as a return value of create()
authorJinyong Ha <jy200.ha@samsung.com>
Mon, 24 May 2021 09:37:37 +0000 (18:37 +0900)
committermyoungwon oh <ohmyoungwon@gmail.com>
Tue, 15 Jun 2021 02:09:06 +0000 (11:09 +0900)
Signed-off-by: Jinyong Ha <jy200.ha@samsung.com>
src/crimson/os/seastore/nvmedevice/nvmedevice.h
src/test/crimson/seastore/nvmedevice/test_nvmedevice.cc

index ee8965a6fe37d0f06e15a7ae9850eee3695fce52..c13ec796fc75f43ef9fe9fad5b359eb945837d94 100644 (file)
@@ -154,8 +154,8 @@ public:
   virtual ~NVMeBlockDevice() = default;
 
   template <typename T>
-  static NVMeBlockDevice *create() {
-    return new T();
+  static std::unique_ptr<T> create() {
+    return std::make_unique<T>();
   }
 
   /*
index 1d79a01ec0cf3deb08063b3f91911b534d1fbfd7..7dfaece9ef75fa99242783b1dc160d550e15154f 100644 (file)
@@ -12,7 +12,7 @@ using namespace crimson::os::seastore;
 using namespace nvme_device;
 
 struct nvdev_test_t : seastar_test_suite_t {
-  NVMeBlockDevice* device;
+  std::unique_ptr<NVMeBlockDevice> device;
   std::string dev_path;
 
   static const uint64_t DEV_SIZE = 1024 * 1024 * 1024;