os/bluestore/BlueFS: do not flush metadata on flush()

That's what fsync is for.  Moreover, this can lead to some squirreliness
if we trigger this from _flush_log().

Signed-off-by: Sage Weil <sage@redhat.com>

diff --git a/src/os/bluestore/BlueFS.cc b/src/os/bluestore/BlueFS.cc
index 56d7f4af8f5d41ada8cbc83e9eef31c64dac5039..060d8e3672d073c710ecd452972f02c46c8b2ab8 100644 (file)
--- a/src/os/bluestore/BlueFS.cc
+++ b/src/os/bluestore/BlueFS.cc
@@ -988,12 +988,7 @@ int BlueFS::_flush(FileWriter *h, bool force)
     return 0;
   }
   if (length == 0) {
-    if (h->file->dirty) {
-      dout(10) << __func__ << " " << h << " no data, flushing metadata on "
-              << h->file->fnode << dendl;
-      return _flush_log();
-    }
-    dout(10) << __func__ << " " << h << " no dirty data or metadata on "
+    dout(10) << __func__ << " " << h << " no dirty data on "
             << h->file->fnode << dendl;
     return 0;
   }