]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
tests: unittest_rocksdb_option: remove deprecated option
authorKefu Chai <kchai@redhat.com>
Wed, 12 Apr 2017 05:56:01 +0000 (13:56 +0800)
committerKefu Chai <kchai@redhat.com>
Wed, 12 Apr 2017 05:59:42 +0000 (13:59 +0800)
* disable_data_sync was removed from rocksdb, see
  https://github.com/facebook/rocksdb/blob/02799ad77a16332ee5bfb570f62ab6162a788a5a/HISTORY.md#530-03082017.
  so remove it.
* and check options.compression, which was commented out.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/test/objectstore/TestRocksdbOptionParse.cc

index f83740ae69e520a8b9029ff42d7e67b37d21bc9b..aae81bed4d612df3384b00a836f43112721d4194 100644 (file)
@@ -25,8 +25,7 @@ TEST(RocksDBOption, simple) {
                          "max_bytes_for_level_base = 104857600;"
                          "target_file_size_base = 10485760;"
                          "num_levels = 3;"
-                         "compression = kNoCompression;"
-                         "disable_data_sync = false;";
+                         "compression = kNoCompression;";
   int r = db->ParseOptionsFromString(options_string, options);
   ASSERT_EQ(0, r);
   ASSERT_EQ(536870912u, options.write_buffer_size);
@@ -38,8 +37,7 @@ TEST(RocksDBOption, simple) {
   ASSERT_EQ(104857600u, options.max_bytes_for_level_base);
   ASSERT_EQ(10485760u, options.target_file_size_base);
   ASSERT_EQ(3, options.num_levels);
-  ASSERT_FALSE(options.disableDataSync);
- // ASSERT_EQ("none", options.compression);
+  ASSERT_EQ(rocksdb::kNoCompression, options.compression);
 }
 TEST(RocksDBOption, interpret) {
   rocksdb::Options options;