]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mon: initialize ProgressEvent::add_to_ceph_s 55070/head
authorPrashant D <pdhange@redhat.com>
Fri, 5 Jan 2024 22:26:46 +0000 (17:26 -0500)
committerPrashant D <pdhange@redhat.com>
Fri, 5 Jan 2024 22:31:11 +0000 (17:31 -0500)
The add_to_ceph_s field was not initialized causing unit
test failures from check-generated.sh:

**** ProgressEvent test 1 dump_json check failed ****
   ceph-dencoder type ProgressEvent select_test 1 dump_json > /tmp/typ-akwRrjNtt
   ceph-dencoder type ProgressEvent select_test 1 encode decode dump_json > /tmp/typ-iDmGaq17A
4c4
<     "add_to_ceph_s": false
---
>     "add_to_ceph_s": true

Fixes: https://tracker.ceph.com/issues/63950
Signed-off-by: Prashant D <pdhange@redhat.com>
src/mon/mon_types.h

index 91502443d426008f000538286766158a3af099ee..3429a8e9991629c68daf474fbc0a1a07f5596c2e 100644 (file)
@@ -684,7 +684,7 @@ inline std::ostream& operator<<(std::ostream& out, const mon_feature_t& f) {
 struct ProgressEvent {
   std::string message;                  ///< event description
   float progress = 0.0f;                  ///< [0..1]
-  bool add_to_ceph_s;
+  bool add_to_ceph_s = false;
   void encode(ceph::buffer::list& bl) const {
     ENCODE_START(2, 1, bl);
     encode(message, bl);