]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mgr/dashboard: Fix long running RBD cloning / copying message 24641/head
authorRicardo Marques <rimarques@suse.com>
Wed, 17 Oct 2018 17:18:24 +0000 (18:18 +0100)
committerRicardo Marques <rimarques@suse.com>
Thu, 25 Oct 2018 11:18:21 +0000 (12:18 +0100)
Fixes: https://tracker.ceph.com/issues/36484
Signed-off-by: Ricardo Marques <rimarques@suse.com>
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-list/rbd-list.component.spec.ts
src/pybind/mgr/dashboard/frontend/src/app/ceph/block/rbd-list/rbd-list.component.ts

index b5d259ea99a73b3a3cd9000544b05bc3dbe42c25..b15bb8dd6c195ca627df2f44df3feea984260746 100644 (file)
@@ -107,14 +107,26 @@ describe('RbdListComponent', () => {
     const addTask = (name: string, image_name: string) => {
       const task = new ExecutingTask();
       task.name = name;
-      task.metadata = {
-        pool_name: 'rbd',
-        image_name: image_name,
-        child_pool_name: 'rbd',
-        child_image_name: 'd',
-        dest_pool_name: 'rbd',
-        dest_image_name: 'd'
-      };
+      switch (task.name) {
+        case 'rbd/copy':
+          task.metadata = {
+            dest_pool_name: 'rbd',
+            dest_image_name: 'd'
+          };
+          break;
+        case 'rbd/clone':
+          task.metadata = {
+            child_pool_name: 'rbd',
+            child_image_name: 'd'
+          };
+          break;
+        default:
+          task.metadata = {
+            pool_name: 'rbd',
+            image_name: image_name
+          };
+          break;
+      }
       summaryService.addRunningTask(task);
     };
 
index 5db4a6a67e2d8f575f0320d86dc9eacbbf327483..78fbc60c1d3978097d9be0944013792800acfb47 100644 (file)
@@ -232,8 +232,24 @@ export class RbdListComponent implements OnInit {
   }
 
   itemFilter(entry, task) {
+    let pool_name_k: string;
+    let image_name_k: string;
+    switch (task.name) {
+      case 'rbd/copy':
+        pool_name_k = 'dest_pool_name';
+        image_name_k = 'dest_image_name';
+        break;
+      case 'rbd/clone':
+        pool_name_k = 'child_pool_name';
+        image_name_k = 'child_image_name';
+        break;
+      default:
+        pool_name_k = 'pool_name';
+        image_name_k = 'image_name';
+        break;
+    }
     return (
-      entry.pool_name === task.metadata['pool_name'] && entry.name === task.metadata['image_name']
+      entry.pool_name === task.metadata[pool_name_k] && entry.name === task.metadata[image_name_k]
     );
   }