]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
Make <poolname> in "ceph osd tier --help" clearer.
authorAccela Zhao <accelazh@gmail.com>
Wed, 18 Jun 2014 09:17:03 +0000 (17:17 +0800)
committerSage Weil <sage@inktank.com>
Wed, 25 Jun 2014 20:15:47 +0000 (13:15 -0700)
The ceph osd tier --help info on the left always says <poolname>.
It is unclear which one to put <tierpool> on the right.

$ceph osd tier --help
osd tier add <poolname> <poolname> {--   add the tier <tierpool> to base pool
force-nonempty}                          <pool>
osd tier add-cache <poolname>            add a cache <tierpool> of size <size>
<poolname> <int[0-]>                     to existing pool <pool>
...

This patch modifies description on the right to tell which <poolname>:

osd tier add <poolname> <poolname> {--   add the tier <tierpool> (the second
 force-nonempty}                          one) to base pool <pool> (the first
                                           one)
...

Fix: http://tracker.ceph.com/issues/8256

Signed-off-by: Yilong Zhao <accelazh@gmail.com>
src/mon/MonCommands.h

index b11e8524edd581d8513be33054882ec057849813..993589360ebd2de4884468c16b54e213cb3c04cc 100644 (file)
@@ -590,11 +590,13 @@ COMMAND("osd tier add " \
        "name=pool,type=CephPoolname " \
        "name=tierpool,type=CephPoolname " \
        "name=force_nonempty,type=CephChoices,strings=--force-nonempty,req=false",
-       "add the tier <tierpool> to base pool <pool>", "osd", "rw", "cli,rest")
+       "add the tier <tierpool> (the second one) to base pool <pool> (the first one)", \
+       "osd", "rw", "cli,rest")
 COMMAND("osd tier remove " \
        "name=pool,type=CephPoolname " \
        "name=tierpool,type=CephPoolname",
-       "remove the tier <tierpool> from base pool <pool>", "osd", "rw", "cli,rest")
+       "remove the tier <tierpool> (the second one) from base pool <pool> (the first one)", \
+       "osd", "rw", "cli,rest")
 COMMAND("osd tier cache-mode " \
        "name=pool,type=CephPoolname " \
        "name=mode,type=CephChoices,strings=none|writeback|forward|readonly", \
@@ -611,7 +613,7 @@ COMMAND("osd tier add-cache " \
        "name=pool,type=CephPoolname " \
        "name=tierpool,type=CephPoolname " \
        "name=size,type=CephInt,range=0", \
-       "add a cache <tierpool> of size <size> to existing pool <pool>", \
+       "add a cache <tierpool> (the second one) of size <size> to existing pool <pool> (the first one)", \
        "osd", "rw", "cli,rest")
 
 /*