]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
cephadm/serve: fix can not find attr.
authorRongqi Sun <sunrongqi@huawei.com>
Thu, 16 Mar 2023 09:22:17 +0000 (17:22 +0800)
committerRongqi Sun <sunrongqi@huawei.com>
Thu, 16 Mar 2023 09:24:22 +0000 (17:24 +0800)
Signed-off-by: Rongqi Sun <sunrongqi@huawei.com>
src/pybind/mgr/cephadm/serve.py

index b53f72eb5814e87649b14f27f73ec93850c0e3ad..269e943cb450ac91370577959985883cbfcee53b 100644 (file)
@@ -1265,10 +1265,7 @@ class CephadmServe:
                 ]
 
                 if daemon_spec.daemon_type == 'osd':
-                    if hasattr(self.mgr.spec_store.active_specs.get(daemon_spec.service_name), "objectstore"):
-                        osd_objectstore = self.mgr.spec_store.active_specs.get(daemon_spec.service_name).objectstore
-                    else:
-                        osd_objectstore = 'bluestore'
+                    osd_objectstore = getattr(self.mgr.spec_store.active_specs.get(daemon_spec.service_name), 'objectstore', 'bluestore')
                     cmd += '--objectstore', osd_objectstore,
 
                 out, err, code = await self._run_cephadm(
@@ -1548,13 +1545,12 @@ class CephadmServe:
             await self._registry_login(host, json.loads(str(self.mgr.get_store('registry_credentials'))))
 
         j = None
-        if not self.mgr.use_repo_digest:
-            try:
-                j = await self._run_cephadm_json(host, '', 'inspect-image', [],
-                                                 image=image_name, no_fsid=True,
-                                                 error_ok=True)
-            except OrchestratorError:
-                pass
+        try:
+            j = await self._run_cephadm_json(host, '', 'inspect-image', [],
+                                             image=image_name, no_fsid=True,
+                                             error_ok=True)
+        except OrchestratorError:
+            pass
 
         if not j:
             pullargs: List[str] = []