common/ConfUtils: check key before actually normalizing

Key normalization involves some copying and strlens, and these are
expensive.
Check if key contain whitespaces, normalize it only when it does.

Signed-off-by: Piotr Dałek <piotr.dalek@corp.ovh.com>

diff --git a/src/common/ConfUtils.cc b/src/common/ConfUtils.cc
index db957760bf9a704ca4c6b4b634089966374f8fd3..c40cdce61bfa871ec8d5b4e05143ff0dbdbb6787 100644 (file)
--- a/src/common/ConfUtils.cc
+++ b/src/common/ConfUtils.cc
@@ -252,6 +252,10 @@ trim_whitespace(std::string &str, bool strip_internal)
 std::string ConfFile::
 normalize_key_name(const std::string &key)
 {
+  if (key.find_first_of(" \t\r\n\f\v\xa0") == string::npos) {
+    return key;
+  }
+
   string k(key);
   ConfFile::trim_whitespace(k, true);
   std::replace(k.begin(), k.end(), ' ', '_');