client: handle fh cleanup in ll_create() failure path

Release the fh if we fail the permissions check.

Signed-off-by: Sage Weil <sage@inktank.com>

diff --git a/src/client/Client.cc b/src/client/Client.cc
index 795d58202006c97befb5bcbee78fc044b6032c59..c57b7131fdcd46c189dbc90e6018bec1ee2a3ea4 100644 (file)
--- a/src/client/Client.cc
+++ b/src/client/Client.cc
@@ -7465,9 +7465,12 @@ int Client::ll_create(vinodeno_t parent, const char *name, mode_t mode, int flag
 
   if (!created) {
     r = check_permissions(in, flags, uid, gid);
-    if (r < 0)
+    if (r < 0) {
+      if (*fhp) {
+       _release_fh(*fhp);
+      }
       goto out;
-
+    }
     if (*fhp == NULL) {
       r = _open(in, flags, mode, fhp);
       if (r < 0)