osd: Fix Valgrind UninitCondition error in ECTransaction::Generate::Generate()

first_interval_in_write can be accessed before it has been initialized. This
is harmless as at worst it will just cause the 1st I/O to a FastEC PG to be
slightly slower than necessary by disabling some optimizations.

However it needs fixing so the teuthology Valgrind job can check for other
issues.

Fixes: https://tracker.ceph.com/issues/76953
Signed-off-by: Bill Scales <bill_scales@uk.ibm.com>

diff --git a/src/osd/ECCommon.h b/src/osd/ECCommon.h
index c51a3150ce73462ba640a17e33fa099a679f80c8..eedcc02383b2471532795e705843585fe71dc233 100644 (file)
--- a/src/osd/ECCommon.h
+++ b/src/osd/ECCommon.h
@@ -729,7 +729,7 @@ struct ECCommon {
     // Set by on_change, forces first write in each interval to be
     // a full write to avoid PWLC spanning intervals. Fixes
     // https://tracker.ceph.com/issues/73891
-    bool first_write_in_interval;
+    bool first_write_in_interval = false;
 
     RMWPipeline(CephContext *cct,
                 ceph::ErasureCodeInterfaceRef ec_impl,