]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
mon/MonCommands: remove obsolete mds commands 41786/head
authorKefu Chai <kchai@redhat.com>
Wed, 9 Jun 2021 09:31:42 +0000 (17:31 +0800)
committerKefu Chai <kchai@redhat.com>
Wed, 9 Jun 2021 10:17:05 +0000 (18:17 +0800)
* "mds dump"
  "mds getmap",
  "mds stop",
  "mds set_max_mds",
  "mds set",
  "mds rmfailed"
  "mds add_data_pool"
  "mds rm_data_pool"
  "mds remove_data_pool"
  the commands above were marked "OBSOLETE" back in
  a8fc92933bb24fe8ed06407335746f1262d6aea8, which was included in v13.0.1,
* "mds tell" was marked obsolete in
  e0d1127205bb45bb623a50b4b68ae85f7b083e04, which was included in v12.0.2,
* "mds deactivate" was marked obsolete in
  c7bd6f02c74513f29be12ae47808ca1a1ddaec9f, which was included in v13.1.0,
* "mds newfs" was marked obsolete in
  072c41e3492a13525d2a45465ed580fc1426fbd1, which was included by v12.0.2

so according to our command retirement policy proposed by
https://ceph-users.ceph.narkive.com/iUh4e0nj/rfc-deprecating-ceph-tool-commands

> Once two major releases go by, the command will then enter the OBSOLETE
> period. This would be one major release, during which the command would
> no longer work although still acknowledged. A simple message down the
> lines of 'This command is now obsolete; please check the docs' would
> suffice to inform the user.

since the next release will be v17. it's been long enough for retiring
these OBSOLETE commands.

Signed-off-by: Kefu Chai <kchai@redhat.com>
src/mon/MonCommands.h

index 2700c4fbe14184226245890392ce4a2dcae90233..045565ecda33e0754d043f1baa205098e5980f30 100644 (file)
@@ -281,16 +281,9 @@ COMMAND("versions",
  */
 
 COMMAND_WITH_FLAG("mds stat", "show MDS status", "mds", "r", FLAG(HIDDEN))
-COMMAND_WITH_FLAG("mds dump "
-       "name=epoch,type=CephInt,req=false,range=0",
-       "dump legacy MDS cluster info, optionally from epoch",
-        "mds", "r", FLAG(OBSOLETE))
 COMMAND("fs dump "
        "name=epoch,type=CephInt,req=false,range=0",
        "dump all CephFS status, optionally from epoch", "mds", "r")
-COMMAND_WITH_FLAG("mds getmap "
-       "name=epoch,type=CephInt,req=false,range=0",
-       "get MDS map, optionally from epoch", "mds", "r", FLAG(OBSOLETE))
 COMMAND("mds metadata name=who,type=CephString,req=false",
        "fetch metadata for mds <role>",
        "mds", "r")
@@ -300,29 +293,11 @@ COMMAND("mds count-metadata name=property,type=CephString",
 COMMAND("mds versions",
        "check running versions of MDSs",
        "mds", "r")
-COMMAND_WITH_FLAG("mds tell "
-       "name=who,type=CephString "
-       "name=args,type=CephString,n=N",
-       "send command to particular mds", "mds", "rw", FLAG(OBSOLETE))
 COMMAND("mds compat show", "show mds compatibility settings",
        "mds", "r")
-COMMAND_WITH_FLAG("mds stop name=role,type=CephString", "stop mds",
-       "mds", "rw", FLAG(OBSOLETE))
-COMMAND_WITH_FLAG("mds deactivate name=role,type=CephString",
-        "clean up specified MDS rank (use with `set max_mds` to shrink cluster)",
-       "mds", "rw", FLAG(OBSOLETE))
 COMMAND("mds ok-to-stop name=ids,type=CephString,n=N",
        "check whether stopping the specified MDS would reduce immediate availability",
        "mds", "r")
-COMMAND_WITH_FLAG("mds set_max_mds "
-       "name=maxmds,type=CephInt,range=0",
-       "set max MDS index", "mds", "rw", FLAG(OBSOLETE))
-COMMAND_WITH_FLAG("mds set "
-       "name=var,type=CephChoices,strings=max_mds|max_file_size|inline_data|"
-       "allow_new_snaps|allow_multimds|allow_multimds_snaps|allow_dirfrags "
-       "name=val,type=CephString "
-       "name=yes_i_really_mean_it,type=CephBool,req=false",
-       "set mds parameter <var> to <val>", "mds", "rw", FLAG(OBSOLETE))
 COMMAND_WITH_FLAG("mds freeze name=role_or_gid,type=CephString"
        " name=val,type=CephString",
        "freeze MDS yes/no", "mds", "rw", FLAG(HIDDEN))
@@ -344,29 +319,12 @@ COMMAND("mds rm "
 COMMAND_WITH_FLAG("mds rmfailed name=role,type=CephString "
         "name=yes_i_really_mean_it,type=CephBool,req=false",
        "remove failed rank", "mds", "rw", FLAG(HIDDEN))
-COMMAND_WITH_FLAG("mds cluster_down", "take MDS cluster down", "mds", "rw", FLAG(OBSOLETE))
-COMMAND_WITH_FLAG("mds cluster_up", "bring MDS cluster up", "mds", "rw", FLAG(OBSOLETE))
 COMMAND("mds compat rm_compat "
        "name=feature,type=CephInt,range=0",
        "remove compatible feature", "mds", "rw")
 COMMAND("mds compat rm_incompat "
        "name=feature,type=CephInt,range=0",
        "remove incompatible feature", "mds", "rw")
-COMMAND_WITH_FLAG("mds add_data_pool "
-       "name=pool,type=CephString",
-       "add data pool <pool>", "mds", "rw", FLAG(OBSOLETE))
-COMMAND_WITH_FLAG("mds rm_data_pool "
-       "name=pool,type=CephString",
-       "remove data pool <pool>", "mds", "rw", FLAG(OBSOLETE))
-COMMAND_WITH_FLAG("mds remove_data_pool "
-       "name=pool,type=CephString",
-       "remove data pool <pool>", "mds", "rw", FLAG(OBSOLETE))
-COMMAND_WITH_FLAG("mds newfs "
-       "name=metadata,type=CephInt,range=0 "
-       "name=data,type=CephInt,range=0 "
-       "name=yes_i_really_mean_it,type=CephBool,req=false",
-       "make new filesystem using pools <metadata> and <data>",
-       "mds", "rw", FLAG(OBSOLETE))
 COMMAND("fs new "
        "name=fs_name,type=CephString,goodchars=[A-Za-z0-9-_.] "
        "name=metadata,type=CephString "