]> git-server-git.apps.pok.os.sepia.ceph.com Git - ceph.git/commitdiff
test/librbd: fix group_info.name leaks in TestGroup.add_image 44500/head
authorIlya Dryomov <idryomov@gmail.com>
Sat, 8 Jan 2022 13:18:32 +0000 (14:18 +0100)
committerIlya Dryomov <idryomov@gmail.com>
Mon, 10 Jan 2022 17:49:06 +0000 (18:49 +0100)
Introduced in commit c04e8c3374e0 ("test/librbd: add get_group test").

Signed-off-by: Ilya Dryomov <idryomov@gmail.com>
src/test/librbd/test_Groups.cc

index 8be7e2abab312d7e0b2101247c99f1d7f719b2a9..88b19146f161ea4e9cd018cf1f6ca262154a000a 100644 (file)
@@ -99,8 +99,9 @@ TEST_F(TestGroup, add_image)
 
   rbd_group_info_t group_info;
   ASSERT_EQ(0, rbd_get_group(image, &group_info, sizeof(group_info)));
-  ASSERT_EQ(0,strcmp("", group_info.name));
+  ASSERT_EQ(0, strcmp("", group_info.name));
   ASSERT_EQ(RBD_GROUP_INVALID_POOL, group_info.pool);
+  rbd_group_info_cleanup(&group_info, sizeof(group_info));
 
   ASSERT_EQ(0, rbd_group_image_add(ioctx, group_name, ioctx,
                                    m_image_name.c_str()));
@@ -109,6 +110,7 @@ TEST_F(TestGroup, add_image)
   ASSERT_EQ(0, rbd_get_group(image, &group_info, sizeof(group_info)));
   ASSERT_EQ(0, strcmp(group_name, group_info.name));
   ASSERT_EQ(rados_ioctx_get_id(ioctx), group_info.pool);
+  rbd_group_info_cleanup(&group_info, sizeof(group_info));
 
   ASSERT_EQ(0, rbd_get_features(image, &features));
   ASSERT_TRUE((features & RBD_FEATURE_OPERATIONS) ==