librados: fix common_init_finish timing

Common_init_finish does start_service_thread and does
set_safe_to_start_threads() on the cct, which switches us to 'runtime'
mode where we can't accept many config options. Do that *after* we fetch
our config from the mon so that we can accept+set runtime options (and
not complain to stderr about it).

Signed-off-by: Sage Weil <sage@redhat.com>

diff --git a/src/librados/RadosClient.cc b/src/librados/RadosClient.cc
index efbd6b563fb893ec571214a9efdfc96655727ffd..06436be1835dcafe609727f839c1c6910fabb830 100644 (file)
--- a/src/librados/RadosClient.cc
+++ b/src/librados/RadosClient.cc
@@ -237,8 +237,6 @@ int librados::RadosClient::ping_monitor(const string mon_id, string *result)
 
 int librados::RadosClient::connect()
 {
-  common_init_finish(cct);
-
   int err;
 
   // already connected?
@@ -255,6 +253,8 @@ int librados::RadosClient::connect()
       return err;
   }
 
+  common_init_finish(cct);
+
   // get monmap
   err = monclient.build_initial_monmap();
   if (err < 0)