]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
osd: drop the lambda wrapping from objects_read_and_reconstruct()
authorRadosław Zarzyński <rzarzyns@redhat.com>
Thu, 14 Sep 2023 13:02:05 +0000 (15:02 +0200)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Wed, 10 Jan 2024 17:23:14 +0000 (17:23 +0000)
Signed-off-by: Radosław Zarzyński <rzarzyns@redhat.com>
src/osd/ECBackend.cc

index d72751c4c36c484f9e1c157c5195ccbaef6517f4..a1d777cba2485bb4a8c7c1c6ec5825b21d1bf243 100644 (file)
@@ -2482,27 +2482,13 @@ void ECBackend::objects_read_and_reconstruct(
 }
 
 void ECBackend::ReadPipeline::objects_read_and_reconstruct(
-  ECBackend& ecbackend,
+  ECBackend& ec_backend,
   const map<hobject_t,
     std::list<boost::tuple<uint64_t, uint64_t, uint32_t> >
   > &reads,
   bool fast_read,
   GenContextURef<map<hobject_t,pair<int, extent_map> > &&> &&func)
 {
-  return [this,
-    kick_reads=[this] (auto...) { return this->kick_reads();},
-    get_want_to_read_shards=[&ecbackend] (auto&&... args) {
-      return ecbackend.get_want_to_read_shards(std::forward<decltype(args)>(args)...);
-    },
-    get_min_avail_to_read_shards=[&ecbackend] (auto&&... args) {
-      return ecbackend.get_min_avail_to_read_shards(std::forward<decltype(args)>(args)...);
-    },
-    cct=(CephContext*)nullptr,
-    // params
-    &reads,
-    fast_read,
-    func=std::move(func)
-  ]() mutable {
   in_progress_client_reads.emplace_back(
     reads.size(), std::move(func));
   if (!reads.size()) {
@@ -2512,12 +2498,12 @@ void ECBackend::ReadPipeline::objects_read_and_reconstruct(
 
   map<hobject_t, set<int>> obj_want_to_read;
   set<int> want_to_read;
-  get_want_to_read_shards(&want_to_read);
+  ec_backend.get_want_to_read_shards(&want_to_read);
     
   map<hobject_t, read_request_t> for_read_op;
   for (auto &&to_read: reads) {
     map<pg_shard_t, vector<pair<int, int>>> shards;
-    int r = get_min_avail_to_read_shards(
+    int r = ec_backend.get_min_avail_to_read_shards(
       to_read.first,
       want_to_read,
       false,
@@ -2543,8 +2529,6 @@ void ECBackend::ReadPipeline::objects_read_and_reconstruct(
     fast_read,
     false,
     std::make_unique<ClientReadCompleter>(*this, &(in_progress_client_reads.back())));
-  }();
-  return;
 }