rgw: refactor RGWDeleteMultiObj formatter_flush_cond member to local var in execute()

Make formatter_flush_cond a local variable in RGWDeleteMultiObj::execute().

Signed-off-by: Cory Snyder <csnyder@iland.com>

diff --git a/src/rgw/rgw_op.cc b/src/rgw/rgw_op.cc
index 0554618ac72d08715ee8e8fd3f87c39336f450a3..133a2e3c24ff13c9bc1c8ec4b0c8cdc3c401e8d4 100644 (file)
--- a/src/rgw/rgw_op.cc
+++ b/src/rgw/rgw_op.cc
@@ -6839,9 +6839,11 @@ void RGWDeleteMultiObj::write_ops_log_entry(rgw_log_entry& entry) const {
   entry.delete_multi_obj_meta.objects = std::move(ops_log_entries);
 }
 
-void RGWDeleteMultiObj::wait_flush(optional_yield y, std::function<bool()> predicate)
+void RGWDeleteMultiObj::wait_flush(optional_yield y,
+                                   boost::asio::deadline_timer *formatter_flush_cond,
+                                  std::function<bool()> predicate)
 {
-  if (y) {
+  if (y && formatter_flush_cond) {
     auto yc = y.get_yield_context();
     while (!predicate()) {
       boost::system::error_code error;
@@ -6851,7 +6853,8 @@ void RGWDeleteMultiObj::wait_flush(optional_yield y, std::function<bool()> predi
   }
 }
 
-void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key *o, optional_yield y)
+void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key *o, optional_yield y,
+                                                 boost::asio::deadline_timer *formatter_flush_cond)
 {
   std::string version_id;
   std::unique_ptr<rgw::sal::Object> obj = bucket->get_object(*o);
@@ -6862,7 +6865,7 @@ void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key *o, optional_
                                                                  rgw::IAM::s3DeleteObjectVersion,
                                                                  ARN(obj->get_obj()));
     if (identity_policy_res == Effect::Deny) {
-      send_partial_response(*o, false, "", -EACCES);
+      send_partial_response(*o, false, "", -EACCES, formatter_flush_cond);
       return;
     }
 
@@ -6879,7 +6882,7 @@ void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key *o, optional_
                               princ_type);
     }
     if (e == Effect::Deny) {
-      send_partial_response(*o, false, "", -EACCES);
+      send_partial_response(*o, false, "", -EACCES, formatter_flush_cond);
       return;
     }
 
@@ -6890,34 +6893,34 @@ void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key *o, optional_
                                                                   rgw::IAM::s3DeleteObjectVersion,
                                                                   ARN(obj->get_obj()));
       if (session_policy_res == Effect::Deny) {
-        send_partial_response(*o, false, "", -EACCES);
+        send_partial_response(*o, false, "", -EACCES, formatter_flush_cond);
         return;
       }
       if (princ_type == rgw::IAM::PolicyPrincipal::Role) {
         //Intersection of session policy and identity policy plus intersection of session policy and bucket policy
         if ((session_policy_res != Effect::Allow || identity_policy_res != Effect::Allow) &&
             (session_policy_res != Effect::Allow || e != Effect::Allow)) {
-          send_partial_response(*o, false, "", -EACCES);
+          send_partial_response(*o, false, "", -EACCES, formatter_flush_cond);
           return;
         }
       } else if (princ_type == rgw::IAM::PolicyPrincipal::Session) {
         //Intersection of session policy and identity policy plus bucket policy
         if ((session_policy_res != Effect::Allow || identity_policy_res != Effect::Allow) && e != Effect::Allow) {
-          send_partial_response(*o, false, "", -EACCES);
+          send_partial_response(*o, false, "", -EACCES, formatter_flush_cond);
           return;
         }
       } else if (princ_type == rgw::IAM::PolicyPrincipal::Other) {// there was no match in the bucket policy
         if (session_policy_res != Effect::Allow || identity_policy_res != Effect::Allow) {
-          send_partial_response(*o, false, "", -EACCES);
+          send_partial_response(*o, false, "", -EACCES, formatter_flush_cond);
           return;
         }
       }
-      send_partial_response(*o, false, "", -EACCES);
+      send_partial_response(*o, false, "", -EACCES, formatter_flush_cond);
       return;
     }
 
     if ((identity_policy_res == Effect::Pass && e == Effect::Pass && !acl_allowed)) {
-      send_partial_response(*o, false, "", -EACCES);
+      send_partial_response(*o, false, "", -EACCES, formatter_flush_cond);
       return;
     }
   }
@@ -6936,7 +6939,7 @@ void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key *o, optional_
         check_obj_lock = false;
       } else {
         // Something went wrong.
-        send_partial_response(*o, false, "", ret);
+        send_partial_response(*o, false, "", ret, formatter_flush_cond);
         return;
       }
     } else {
@@ -6948,7 +6951,7 @@ void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key *o, optional_
       ceph_assert(astate);
       int object_lock_response = verify_object_lock(this, astate->attrset, bypass_perm, bypass_governance_mode);
       if (object_lock_response != 0) {
-        send_partial_response(*o, false, "", object_lock_response);
+        send_partial_response(*o, false, "", object_lock_response, formatter_flush_cond);
         return;
       }
     }
@@ -6963,7 +6966,7 @@ void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key *o, optional_
           = store->get_notification(obj.get(), s->src_object.get(), s, event_type);
   op_ret = res->publish_reserve(this);
   if (op_ret < 0) {
-    send_partial_response(*o, false, "", op_ret);
+    send_partial_response(*o, false, "", op_ret, formatter_flush_cond);
     return;
   }
 
@@ -6980,7 +6983,7 @@ void RGWDeleteMultiObj::handle_individual_object(const rgw_obj_key *o, optional_
     op_ret = 0;
   }
 
-  send_partial_response(*o, obj->get_delete_marker(), del_op->result.version_id, op_ret);
+  send_partial_response(*o, obj->get_delete_marker(), del_op->result.version_id, op_ret, formatter_flush_cond);
 
   // send request to notification manager
   int ret = res->publish_commit(this, obj_size, ceph::real_clock::now(), etag, version_id);
@@ -6996,8 +6999,9 @@ void RGWDeleteMultiObj::execute(optional_yield y)
   vector<rgw_obj_key>::iterator iter;
   RGWMultiDelXMLParser parser;
   uint32_t aio_count = 0;
-  uint32_t max_aio = s->cct->_conf->rgw_multi_obj_del_max_aio;
+  const uint32_t max_aio = s->cct->_conf->rgw_multi_obj_del_max_aio;
   char* buf;
+  std::unique_ptr<boost::asio::deadline_timer> formatter_flush_cond;
   if (y) {
     formatter_flush_cond = std::make_unique<boost::asio::deadline_timer>(y.get_io_context());  
   }
@@ -7063,19 +7067,19 @@ void RGWDeleteMultiObj::execute(optional_yield y)
         ++iter) {
     rgw_obj_key* obj_key = &*iter;
     if (y && max_aio > 1) {
-      wait_flush(y, [&aio_count, max_aio] {
+      wait_flush(y, formatter_flush_cond.get(), [&aio_count, max_aio] {
         return aio_count < max_aio;
       });
       aio_count++;
-      spawn::spawn(y.get_yield_context(), [this, &y, &aio_count, obj_key] (yield_context yield) {
-        handle_individual_object(obj_key, optional_yield { y.get_io_context(), yield }); 
+      spawn::spawn(y.get_yield_context(), [this, &y, &aio_count, obj_key, &formatter_flush_cond] (yield_context yield) {
+        handle_individual_object(obj_key, optional_yield { y.get_io_context(), yield }, formatter_flush_cond.get()); 
         aio_count--;
       }); 
     } else {
-      handle_individual_object(obj_key, y);
+      handle_individual_object(obj_key, y, formatter_flush_cond.get());
     }
   }
-  wait_flush(y, [this, n=multi_delete->objects.size()] {
+  wait_flush(y, formatter_flush_cond.get(), [this, n=multi_delete->objects.size()] {
     return n == ops_log_entries.size();
   });
 

diff --git a/src/rgw/rgw_op.h b/src/rgw/rgw_op.h
index 692cb5c50abf31e9a16a13a998383dc9fdc05699..a543198029f8f3f5f3bc8637104bef0bf1c1f975 100644 (file)
--- a/src/rgw/rgw_op.h
+++ b/src/rgw/rgw_op.h
@@ -2033,7 +2033,9 @@ class RGWDeleteMultiObj : public RGWOp {
    * Handles the deletion of an individual object and uses
    * set_partial_response to record the outcome. 
    */
-  void handle_individual_object(const rgw_obj_key *o, optional_yield y);
+  void handle_individual_object(const rgw_obj_key *o,
+                               optional_yield y,
+                                boost::asio::deadline_timer *formatter_flush_cond);
   
   /**
    * When the request is being executed in a coroutine, performs
@@ -2046,20 +2048,12 @@ class RGWDeleteMultiObj : public RGWOp {
    * and saved on the req_state vs. one that is passed on the stack.
    * This is a no-op in the case where we're not executing as a coroutine.
    */
-  void wait_flush(optional_yield y, std::function<bool()> predicate);
+  void wait_flush(optional_yield y,
+                  boost::asio::deadline_timer *formatter_flush_cond,
+                  std::function<bool()> predicate);
 
 protected:
   std::vector<delete_multi_obj_entry> ops_log_entries;
-
-  /**
-   * Acts as an async condition variable when the request is being
-   * executed on a coroutine. Formatter flushing must happen on the main
-   * request coroutine vs. spawned coroutines, so spawned coroutines use
-   * the cancellation of this timer to notify the main coroutine when
-   * data is ready to flush. 
-   */
-  std::unique_ptr<boost::asio::deadline_timer> formatter_flush_cond;
-  
   bufferlist data;
   rgw::sal::Bucket* bucket;
   bool quiet;
@@ -2084,7 +2078,8 @@ public:
   virtual void send_status() = 0;
   virtual void begin_response() = 0;
   virtual void send_partial_response(const rgw_obj_key& key, bool delete_marker,
-                                     const std::string& marker_version_id, int ret) = 0;
+                                     const std::string& marker_version_id, int ret,
+                                     boost::asio::deadline_timer *formatter_flush_cond) = 0;
   virtual void end_response() = 0;
   const char* name() const override { return "multi_object_delete"; }
   RGWOpType get_type() override { return RGW_OP_DELETE_MULTI_OBJ; }

diff --git a/src/rgw/rgw_rest_s3.cc b/src/rgw/rgw_rest_s3.cc
index 4038d3add04b425d2f3029abe0d0be5f8c086aca..2576e31b7eec2c33158989d980b2ce2e1e149fc3 100644 (file)
--- a/src/rgw/rgw_rest_s3.cc
+++ b/src/rgw/rgw_rest_s3.cc
@@ -4141,7 +4141,8 @@ void RGWDeleteMultiObj_ObjStore_S3::begin_response()
 void RGWDeleteMultiObj_ObjStore_S3::send_partial_response(const rgw_obj_key& key,
                                                          bool delete_marker,
                                                          const string& marker_version_id,
-                                                          int ret)
+                                                          int ret,
+                                                          boost::asio::deadline_timer *formatter_flush_cond)
 {
   if (!key.empty()) {
     delete_multi_obj_entry ops_log_entry;

diff --git a/src/rgw/rgw_rest_s3.h b/src/rgw/rgw_rest_s3.h
index 8f304ce941d112753758c2823a183a343ab3bdb3..6b8ef5392507ff1b9f69fe1d03c755122e4c16c8 100644 (file)
--- a/src/rgw/rgw_rest_s3.h
+++ b/src/rgw/rgw_rest_s3.h
@@ -517,7 +517,8 @@ public:
   void send_status() override;
   void begin_response() override;
   void send_partial_response(const rgw_obj_key& key, bool delete_marker,
-                             const std::string& marker_version_id, int ret) override;
+                             const std::string& marker_version_id, int ret,
+                             boost::asio::deadline_timer *formatter_flush_cond) override;
   void end_response() override;
 };