]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crush: remove unused variables 54599/head
authorCasey Bodley <cbodley@redhat.com>
Tue, 21 Nov 2023 18:44:40 +0000 (13:44 -0500)
committerCasey Bodley <cbodley@redhat.com>
Tue, 21 Nov 2023 18:44:41 +0000 (13:44 -0500)
[161/715] Building CXX object src/crush/CMakeFiles/crush_objs.dir/CrushTester.cc.o
ceph/src/crush/CrushTester.cc:478:7: warning: variable 'num_devices_active' set but not used [-Wunused-but-set-variable]
  int num_devices_active = 0;
      ^
1 warning generated.
[165/715] Building CXX object src/crush/CMakeFiles/crush_objs.dir/CrushWrapper.cc.o
ceph/src/crush/CrushWrapper.cc:1579:9: warning: variable 'local_changed' set but not used [-Wunused-but-set-variable]
    int local_changed = 0;
        ^

Signed-off-by: Casey Bodley <cbodley@redhat.com>
src/crush/CrushTester.cc
src/crush/CrushWrapper.cc

index 4f99cffaaa9ef30e9f7b147a984b0f6e54605391..1d659e6a56bfac986956d0b783acc52fc1ba4887 100644 (file)
@@ -474,12 +474,6 @@ int CrushTester::test(CephContext* cct)
   // make adjustments
   adjust_weights(weight);
 
-
-  int num_devices_active = 0;
-  for (vector<__u32>::iterator p = weight.begin(); p != weight.end(); ++p)
-    if (*p > 0)
-      num_devices_active++;
-
   if (output_choose_tries)
     crush.start_choose_profile();
   
index 530c2413933d095b2a287f5d208507e3bcb9e3e8..0f40e6875e1be84ac164d6e8697f714e95003fb9 100644 (file)
@@ -1576,13 +1576,11 @@ int CrushWrapper::adjust_subtree_weight(CephContext *cct, int id, int weight,
   while (!q.empty()) {
     b = q.front();
     q.pop_front();
-    int local_changed = 0;
     for (unsigned i=0; i<b->size; ++i) {
       int n = b->items[i];
       if (n >= 0) {
        adjust_item_weight_in_bucket(cct, n, weight, b->id, update_weight_sets);
        ++changed;
-       ++local_changed;
       } else {
        crush_bucket *sub = get_bucket(n);
        if (IS_ERR(sub))