]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
client/Client.cc: fix USE_AFTER_FREE
authorDanny Al-Gaaf <danny.al-gaaf@bisect.de>
Wed, 10 May 2017 18:42:36 +0000 (20:42 +0200)
committerKefu Chai <kchai@redhat.com>
Sat, 2 Sep 2017 04:07:20 +0000 (12:07 +0800)
Don't call put_request() twice, it's already called by
unregister_request()

Fix for:

CID 1405360 (#1 of 1): Use after free (USE_AFTER_FREE)
 deref_arg: Calling put_request dereferences freed pointer request

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
src/client/Client.cc

index 88b9bf054b5ba1a5a7d145ff2eab46bd0073a0f5..bc74fe8f0076254242a5e4cf6eee2870d71591d7 100644 (file)
@@ -1730,7 +1730,6 @@ int Client::make_request(MetaRequest *request,
     r = request->get_abort_code();
     request->item.remove_myself();
     unregister_request(request);
-    put_request(request); // ours
     return r;
   }