]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
osd: fix heartbeat_reset unlock 25035/head
authorSage Weil <sage@redhat.com>
Mon, 29 Oct 2018 01:21:53 +0000 (20:21 -0500)
committerNathan Cutler <ncutler@suse.com>
Sat, 10 Nov 2018 23:25:01 +0000 (00:25 +0100)
Fixes 51d8e2457d73c709bfa4f706793696b3ce704ff9, which moved to lock_guard
but didn't remove the unlock call on this exit path.

Signed-off-by: Sage Weil <sage@redhat.com>
(cherry picked from commit 1a0e2f7e1518d57bc07176f4297315a7c9a3c139)

Conflicts:
src/osd/OSD.cc
- luminous has a s->put() call that was subsequently removed

src/osd/OSD.cc

index 6e552267b982c8ce2c4fbe7c807f355b0c309238..131628ad53936fbe9d0ee0e5fb26c96117cf91da 100644 (file)
@@ -5259,7 +5259,6 @@ bool OSD::heartbeat_reset(Connection *con)
   HeartbeatSession *s = static_cast<HeartbeatSession*>(con->get_priv());
   if (s) {
     if (is_stopping()) {
-      heartbeat_lock.Unlock();
       s->put();
       return true;
     }