]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson: comment on why OpsExecuter needs PG.
authorRadoslaw Zarzynski <rzarzyns@redhat.com>
Fri, 20 Nov 2020 12:42:32 +0000 (13:42 +0100)
committerRadoslaw Zarzynski <rzarzyns@redhat.com>
Fri, 20 Nov 2020 13:45:59 +0000 (14:45 +0100)
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
src/crimson/osd/pg.cc

index 5c78a5d115b60e4c7196978147a967f63f0a2090..38c913c4d2396c315015df2b84d520f2dbb4d793 100644 (file)
@@ -608,8 +608,10 @@ seastar::future<Ref<MOSDOpReply>> PG::do_osd_ops(
   using osd_op_errorator = OpsExecuter::osd_op_errorator;
   const auto oid = m->get_snapid() == CEPH_SNAPDIR ? m->get_hobj().get_head()
                                                    : m->get_hobj();
+  // OpsExecuter gets PG as non-const as it's responsible for modying
+  // e.g. `projected_last_update`.
   auto ox =
-    std::make_unique<OpsExecuter>(obc, op_info, *this/* as const& */, m);
+    std::make_unique<OpsExecuter>(obc, op_info, *this, m);
 
   return crimson::do_for_each(
     m->ops, [obc, m, ox = ox.get()](OSDOp& osd_op) {