]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
client: resolve bogus self-assignment 60761/head
authorPatrick Donnelly <pdonnell@ibm.com>
Mon, 18 Nov 2024 16:45:32 +0000 (11:45 -0500)
committerPatrick Donnelly <pdonnell@ibm.com>
Mon, 18 Nov 2024 17:00:36 +0000 (12:00 -0500)
Credit to  Ilya Dryomov for spotting this.

[1] https://github.com/ceph/ceph/pull/60283#discussion_r1846415092

Fixes: 1da6ef237fc70ddd64152d029cd6e0cf8f0c808e
Fixes: https://tracker.ceph.com/issues/68973
Signed-off-by: Patrick Donnelly <pdonnell@ibm.com>
src/client/Client.cc

index c404057b929d7f2f6e6f7c534d1ef3ff356fb219..fd36566a6e9a12b08dcf29dbf4f0c6478da7eb71 100644 (file)
@@ -5524,7 +5524,7 @@ void Client::handle_cap_export(MetaSession *session, Inode *in, const MConstRef<
              ceph_seq_cmp(tcap.seq, m->peer.issue_seq) < 0) {
            tcap.cap_id = m->peer.cap_id;
            tcap.seq = m->peer.issue_seq - 1;
-           tcap.issue_seq = tcap.issue_seq;
+           tcap.issue_seq = m->peer.issue_seq - 1;
            tcap.issued |= cap.issued;
            tcap.implemented |= cap.issued;
            if (&cap == in->auth_cap)