]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
crimson: clarify ops_executer.h comment
authorSamuel Just <sjust@redhat.com>
Thu, 10 Oct 2024 16:22:28 +0000 (16:22 +0000)
committerSamuel Just <sjust@redhat.com>
Tue, 15 Oct 2024 03:37:26 +0000 (20:37 -0700)
Signed-off-by: Samuel Just <sjust@redhat.com>
src/crimson/osd/ops_executer.h

index 6986f49ea08a73b8f54fa954a7d63d7210c2a0e5..3a7aaef7cd0364d95a0a34797f0b3e1cc7e35618 100644 (file)
@@ -170,13 +170,9 @@ public:
 
   object_stat_sum_t delta_stats;
 private:
-  // an operation can be divided into two stages: main and effect-exposing
-  // one. The former is performed immediately on call to `do_osd_op()` while
-  // the later on `submit_changes()` – after successfully processing main
-  // stages of all involved operations. When any stage fails, none of all
-  // scheduled effect-exposing stages will be executed.
-  // when operation requires this division, some variant of `with_effect()`
-  // should be used.
+  // with_effect can be used to schedule operations to be performed
+  // at commit time.  effects will be discarded if the operation does
+  // not commit.
   struct effect_t {
     // an effect can affect PG, i.e. create a watch timeout
     virtual seastar::future<> execute(Ref<PG> pg) = 0;