]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
blk: change configuration name to avoid miss hint 35306/head
authorChangcheng Liu <changcheng.liu@aliyun.com>
Wed, 15 Jul 2020 14:11:12 +0000 (22:11 +0800)
committerChangcheng Liu <changcheng.liu@aliyun.com>
Tue, 21 Jul 2020 05:56:38 +0000 (13:56 +0800)
"bluestore_ioring" has the hint that it only affect bluestore when
it uses KernelDevice/HMSMRDevice driver. However, it also affects
librbd when librbd use blk driver and "bluestore_ioring" is configured
in global section.
Refine the name to avoid this hint.

Suggested-by: Kefu Chai <kefu@redhat.com>
Signed-off-by: Changcheng Liu <changcheng.liu@aliyun.com>
src/blk/kernel/KernelDevice.cc
src/blk/zoned/HMSMRDevice.cc
src/common/options.cc

index ddbed426a2da30c4f12d080792ebb154e4f0eb13..a2d920d0214402839f2e8f554f58aac44d227d98 100644 (file)
@@ -66,7 +66,7 @@ KernelDevice::KernelDevice(CephContext* cct, aio_callback_t cb, void *cbpriv, ai
   fd_directs.resize(WRITE_LIFE_MAX, -1);
   fd_buffereds.resize(WRITE_LIFE_MAX, -1);
 
-  bool use_ioring = cct->_conf.get_val<bool>("bluestore_ioring");
+  bool use_ioring = cct->_conf.get_val<bool>("bdev_ioring");
   unsigned int iodepth = cct->_conf->bdev_aio_max_queue_depth;
 
   if (use_ioring && ioring_queue_t::supported()) {
index a8b574f0562c234fb18f52fbdfd700beb6dda6df..83509724316499baff181a5feba55176df001936 100644 (file)
@@ -60,7 +60,7 @@ HMSMRDevice::HMSMRDevice(CephContext* cct, aio_callback_t cb, void *cbpriv, aio_
   fd_directs.resize(WRITE_LIFE_MAX, -1);
   fd_buffereds.resize(WRITE_LIFE_MAX, -1);
 
-  bool use_ioring = cct->_conf.get_val<bool>("bluestore_ioring");
+  bool use_ioring = cct->_conf.get_val<bool>("bdev_ioring");
   unsigned int iodepth = cct->_conf->bdev_aio_max_queue_depth;
 
   if (use_ioring && ioring_queue_t::supported()) {
index 4605c6eb6f9662c29cb41f86212f29e2cd48d78b..35cd4c3c0d56e446c4829864669dc70203abd92b 100644 (file)
@@ -4712,7 +4712,7 @@ std::vector<Option> get_global_options() {
       .set_default(0)
       .set_description("Space reserved at DB device and not allowed for 'use some extra' policy usage. Overrides 'bluestore_volume_selection_reserved_factor' setting and introduces straightforward limit."),
 
-    Option("bluestore_ioring", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
+    Option("bdev_ioring", Option::TYPE_BOOL, Option::LEVEL_ADVANCED)
     .set_default(false)
     .set_description("Enables Linux io_uring API instead of libaio"),