]> git.apps.os.sepia.ceph.com Git - ceph.git/commitdiff
backport-create-issue: resolve parent only if parent has backport issues 31753/head
authorNathan Cutler <ncutler@suse.com>
Wed, 20 Nov 2019 08:15:33 +0000 (09:15 +0100)
committerNathan Cutler <ncutler@suse.com>
Thu, 12 Dec 2019 16:42:51 +0000 (17:42 +0100)
This fixes an edge case. If a parent issue is in "Pending Backport" status
but without any backport issues, the script (when running with --resolve-parent)
was wrongly changing the status to "Resolved".

Signed-off-by: Nathan Cutler <ncutler@suse.com>
src/script/backport-create-issue

index 02a475e5782b10f62226a9a3b5839e1f6866de7a..a599bd305f71876e89626db1a1bb36272c1bf1c2 100755 (executable)
@@ -246,6 +246,8 @@ def maybe_resolve(issue, backports, dry_run):
     global delay_seconds
     global redmine
     global status2status_id
+    if not backports:
+        return None
     pending_backport_status_id = status2status_id["Pending Backport"]
     resolved_status_id = status2status_id["Resolved"]
     rejected_status_id = status2status_id["Rejected"]