OpTracker: demand that a TrackedOp gets to own its Message for life.

Signed-off-by: Greg Farnum <greg@inktank.com>

diff --git a/src/common/TrackedOp.h b/src/common/TrackedOp.h
index 5d2abf591c4150a311b3048c6b42e7e9f32fba45..94eb4e3f71e029c5079ce3b900e77171805754e9 100644 (file)
--- a/src/common/TrackedOp.h
+++ b/src/common/TrackedOp.h
@@ -140,7 +140,7 @@ protected:
   virtual void init_from_message() {};
 
 public:
-  virtual ~TrackedOp() { if (request) request->put(); }
+  virtual ~TrackedOp() { assert(request); request->put(); }
 
   utime_t get_arrived() const {
     return received_time;

diff --git a/src/osd/OpRequest.h b/src/osd/OpRequest.h
index 9a40c1be2191587665d272c9368c3c6fd8ea0ced..88c4e7d4bc20075d44623fe4afe662a5c060fc6f 100644 (file)
--- a/src/osd/OpRequest.h
+++ b/src/osd/OpRequest.h
@@ -75,10 +75,6 @@ private:
   OpRequest(Message *req, OpTracker *tracker);
 
 public:
-  ~OpRequest() {
-    assert(request);
-  }
-
   bool been_queued_for_pg() { return hit_flag_points & flag_queued_for_pg; }
   bool been_reached_pg() { return hit_flag_points & flag_reached_pg; }
   bool been_delayed() { return hit_flag_points & flag_delayed; }